Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/manual add peer #479

Merged
merged 15 commits into from Oct 3, 2018
Merged

Feature/manual add peer #479

merged 15 commits into from Oct 3, 2018

Conversation

melowe
Copy link
Contributor

@melowe melowe commented Oct 1, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #479 into master will decrease coverage by 0.06%.
The diff coverage is 98.32%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #479      +/-   ##
============================================
- Coverage     99.65%   99.58%   -0.07%     
- Complexity     1169     1184      +15     
============================================
  Files           189      191       +2     
  Lines          3766     3881     +115     
  Branches        194      201       +7     
============================================
+ Hits           3753     3865     +112     
- Partials         13       16       +3
Impacted Files Coverage Δ Complexity Δ
...com/quorum/tessera/jaxrs/client/ClientFactory.java 100% <ø> (ø) 4 <0> (?)
...om/quorum/tessera/client/RestP2pClientFactory.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...a/api/exception/WebApplicationExceptionMapper.java 100% <100%> (ø) 4 <0> (ø) ⬇️
.../java/com/quorum/tessera/node/PartyInfoPoller.java 100% <100%> (ø) 9 <1> (-1) ⬇️
...sera/api/exception/KeyNotFoundExceptionMapper.java 100% <100%> (ø) 3 <0> (ø) ⬇️
.../java/com/quorum/tessera/config/cli/CliResult.java 100% <100%> (ø) 4 <2> (-1) ⬇️
...om/quorum/tessera/config/util/ConfigFileStore.java 100% <100%> (ø) 2 <2> (?)
...rc/main/java/com/quorum/tessera/config/Config.java 100% <100%> (ø) 12 <2> (+1) ⬆️
...a/api/exception/EntityNotFoundExceptionMapper.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...in/java/com/quorum/tessera/api/ConfigResource.java 100% <100%> (ø) 4 <4> (?)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 771491a...79627b3. Read the comment docs.

@prd-fox
Copy link
Contributor

prd-fox commented Oct 2, 2018

Adds groundwork for updatable configuration
Allow a new peer to be added to the configuration, where it can be picked up by services that use them (such as the WhitelistFilter).

Copy link
Contributor

@prd-fox prd-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the assumption that another change is required to enable the new peer to share its key information (PartyInfo).
As mentioned, this just lays some groundwork.

@Krish1979 Krish1979 merged commit d23fea0 into Consensys:master Oct 3, 2018
@Krish1979 Krish1979 deleted the feature/manual-add-peer branch October 3, 2018 10:57
@prd-fox prd-fox added enhancement Non-user code enhancements 0.7 labels Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.7 enhancement Non-user code enhancements review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants