Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Key Vault integration for storage of Tessera public/private key pairs #483

Merged
merged 80 commits into from Oct 15, 2018
Merged

Azure Key Vault integration for storage of Tessera public/private key pairs #483

merged 80 commits into from Oct 15, 2018

Conversation

chris-j-h
Copy link
Collaborator

Added features

  1. Option to save newly generated keys to a preconfigured Azure Key Vault
  2. Retrieve keys from an Azure Key Vault so that they do not have to be stored locally

Main areas of interest

  • key-vault modules: Connecting to the Azure service and providing the means to store and retrieve keys
  • config modules: Adding further config items and corresponding validation
  • key-generation module: Storing keys in vault after generation

chris-j-h and others added 30 commits August 31, 2018 17:25
…m/QuorumEngineering/tessera into feature/key-vault-with-new-key-types

# Conflicts:
#	config/src/main/java/com/quorum/tessera/config/adapters/KeyDataAdapter.java
#	config/src/main/java/com/quorum/tessera/config/constraints/UnsupportedKeyPairValidator.java
#	config/src/main/java/com/quorum/tessera/config/keypairs/ConfigKeyPair.java
#	config/src/main/java/com/quorum/tessera/config/keypairs/DirectKeyPair.java
#	config/src/main/java/com/quorum/tessera/config/keypairs/FilesystemKeyPair.java
#	config/src/main/java/com/quorum/tessera/config/keypairs/InlineKeypair.java
#	config/src/main/java/com/quorum/tessera/config/keypairs/UnsupportedKeyPair.java
#	config/src/main/resources/ValidationMessages.properties
#	config/src/test/java/com/quorum/tessera/config/ValidationTest.java
#	config/src/test/java/com/quorum/tessera/config/adapters/KeyDataAdapterTest.java
#	config/src/test/java/com/quorum/tessera/config/constraints/UnsupportedKeyPairValidatorTest.java
#	config/src/test/java/com/quorum/tessera/config/keypairs/UnsupportedKeyPairTest.java
@codecov-io
Copy link

codecov-io commented Oct 9, 2018

Codecov Report

Merging #483 into master will decrease coverage by 0.1%.
The diff coverage is 97.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #483      +/-   ##
============================================
- Coverage     99.48%   99.38%   -0.11%     
- Complexity     1195     1260      +65     
============================================
  Files           206      217      +11     
  Lines          3914     4070     +156     
  Branches        201      213      +12     
============================================
+ Hits           3894     4045     +151     
- Misses            0        5       +5     
  Partials         20       20
Impacted Files Coverage Δ Complexity Δ
...um/tessera/key/generation/KeyGeneratorFactory.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...rc/main/java/com/quorum/tessera/config/Config.java 100% <ø> (ø) 12 <0> (ø) ⬇️
...tessera/key/vault/AzureKeyVaultClientDelegate.java 0% <0%> (ø) 0 <0> (?)
...ssera/config/adapters/KeyConfigurationAdapter.java 95.23% <100%> (ø) 7 <0> (ø) ⬇️
...onfig/constraints/UnsupportedKeyPairValidator.java 100% <100%> (ø) 12 <1> (+2) ⬆️
...essera/config/cli/parsers/KeyGenerationParser.java 96.29% <100%> (+1.29%) 10 <5> (+2) ⬆️
...essera/key/vault/VaultSecretNotFoundException.java 100% <100%> (ø) 1 <1> (?)
...tessera/key/generation/AzureVaultKeyGenerator.java 100% <100%> (ø) 6 <6> (?)
...rum/tessera/config/keypairs/AzureVaultKeyPair.java 100% <100%> (ø) 7 <7> (?)
...a/com/quorum/tessera/config/JaxbConfigFactory.java 100% <100%> (ø) 12 <2> (ø) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de57253...e3c46e3. Read the comment docs.

@melowe melowe merged commit e6b2053 into Consensys:master Oct 15, 2018
@prd-fox prd-fox added enhancement Non-user code enhancements 0.7 labels Oct 17, 2018
@prd-fox prd-fox deleted the feature/key-vault-with-new-key-types branch November 15, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.7 enhancement Non-user code enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants