Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to 0.7 release #526

Merged
merged 23 commits into from Nov 16, 2018
Merged

Fixes to 0.7 release #526

merged 23 commits into from Nov 16, 2018

Conversation

melowe
Copy link
Contributor

@melowe melowe commented Nov 15, 2018

Issues address from 0.7 release

  1. Peer discovery bug. Peers need to discover each other even if not listed in initial peers list
  2. Update surefire plugin (cherry picked from master)
  3. Trim key values to mirror behaviour in other transaction managers (cherry picked from master)
  4. Add file contents validation to ensure that key files have contents, ensuring that node won't be started.
  5. Empty key value validation. Fixed problem where empty key values were't being validated
  6. Randomise acceptance test node startup order
  7. Add acceptance test scenarios proving that key validation changes in fact work and suppress startup.
  8. Fix for Unauthenticated Denial of Service vulnerability
  9. Fix unit test in AzureVaultKeyGeneratorTest

@codecov-io
Copy link

codecov-io commented Nov 15, 2018

Codecov Report

Merging #526 into patch-release-0.7.1 will increase coverage by 0.53%.
The diff coverage is 100%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##             patch-release-0.7.1     #526      +/-   ##
=========================================================
+ Coverage                  98.88%   99.42%   +0.53%     
- Complexity                  1236     1257      +21     
=========================================================
  Files                        213      211       -2     
  Lines                       3961     3975      +14     
  Branches                     211      212       +1     
=========================================================
+ Hits                        3917     3952      +35     
+ Misses                        26        5      -21     
  Partials                      18       18
Impacted Files Coverage Δ Complexity Δ
.../quorum/tessera/config/keypairs/DirectKeyPair.java 100% <ø> (ø) 5 <0> (ø) ⬇️
...rum/tessera/config/keypairs/FilesystemKeyPair.java 100% <ø> (ø) 12 <0> (ø) ⬇️
.../quorum/tessera/config/keypairs/InlineKeypair.java 100% <ø> (ø) 7 <0> (ø) ⬇️
...sera/api/exception/KeyNotFoundExceptionMapper.java 100% <100%> (ø) 3 <1> (ø) ⬇️
.../quorum/tessera/node/PartyInfoParserException.java 100% <100%> (ø) 1 <1> (?)
...sera/config/constraints/ValidContentValidator.java 100% <100%> (ø) 9 <9> (?)
.../java/com/quorum/tessera/node/PartyInfoParser.java 100% <100%> (ø) 20 <14> (+12) ⬆️
...in/java/com/quorum/tessera/api/ConfigResource.java 100% <100%> (ø) 5 <1> (ø) ⬇️
...orum/tessera/config/keypairs/KeyPairConverter.java 100% <100%> (ø) 4 <0> (ø) ⬇️
...main/java/com/quorum/tessera/node/model/Party.java 100% <100%> (ø) 7 <1> (+1) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6456a11...cacb456. Read the comment docs.

@melowe melowe changed the title Bugfix/partyinfo Address issues found in 0.7 release Nov 15, 2018
@melowe melowe merged commit e544976 into Consensys:patch-release-0.7.1 Nov 16, 2018
@prd-fox prd-fox added 0.7 bug Something isn't working labels Nov 19, 2018
@Krish1979 Krish1979 changed the title Address issues found in 0.7 release Fixes to 0.7 release Nov 19, 2018
@prd-fox prd-fox added 0.7.3 and removed 0.7 labels Nov 19, 2018
@prd-fox prd-fox deleted the bugfix/partyinfo branch January 13, 2019 21:49
@prd-fox prd-fox restored the bugfix/partyinfo branch January 13, 2019 21:49
@prd-fox prd-fox deleted the bugfix/partyinfo branch January 13, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.7.3 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants