-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to 0.7 release #526
Merged
Merged
Fixes to 0.7 release #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a network is created by discovery over configuration.
Add start acceptance tests to ensure that empty key values are validated and startup is supressed.
debug level the message and status is returned to the client.
melowe
requested review from
chris-j-h,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
November 15, 2018 15:12
Codecov Report
@@ Coverage Diff @@
## patch-release-0.7.1 #526 +/- ##
=========================================================
+ Coverage 98.88% 99.42% +0.53%
- Complexity 1236 1257 +21
=========================================================
Files 213 211 -2
Lines 3961 3975 +14
Branches 211 212 +1
=========================================================
+ Hits 3917 3952 +35
+ Misses 26 5 -21
Partials 18 18
Continue to review full report at Codecov.
|
namtruong
approved these changes
Nov 15, 2018
This reverts commit dfe7845.
…n vaultId is invalid - not the whole filepath. This test case used an invalid filepath - which might or might not result in InvalidPathException depending on the default filesystem encoding.
prd-fox
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues address from 0.7 release