Add application configuration that can be used to configure services #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prd-fox
requested review from
melowe,
namtruong and
SatpalSandhu61
as code owners
namtruong
previously approved these changes
Jun 8, 2018
namtruong
approved these changes
Jun 8, 2018
|
|
||
| public enum ConfigHolder { | ||
|
|
||
| INSTANCE; |
There was a problem hiding this comment.
Could we not use longhand here, to make it clearer?
public static final MySingleton INSTANCE = new MySingleton();
There was a problem hiding this comment.
Yeah, this was done to keep it outside the spring xml file, but then it somehow made its way in anyway. Definitely a refactoring consideration, but for now this works.
There was a problem hiding this comment.
Using enum classes for singletons is pretty uncontroversial.
There was a problem hiding this comment.
@mark, sure but it's good to keep things simple. I'd never seen this before and I'm sure there are plenty of folks who'd have to do a quick google to work it out.
melowe
pushed a commit
that referenced
this pull request
Jun 28, 2018
…figuration Add application configuration that can be used to configure services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an initial version of configuration and its holder classes that can be sent around the application.