Use Java 17 for build and runtime #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usmansaleem
added
the
doc-change-required
jframe
reviewed
Apr 11, 2023
| @@ -7,6 +7,7 @@ | |||
| ], | |||
| "transformationRules" : [ | |||
| { "bundleName" : "MIT", "licenseNamePattern" : "\"MIT\\sLicense\"" }, | |||
| { "bundleName" : "MIT", "licenseNamePattern" : "(.*)SPDX-License-Identifier: MIT(.*)" }, | |||
There was a problem hiding this comment.
Was this the io.gatling.gradle update that changed the license name?
There was a problem hiding this comment.
No, this was resulted due to some other library and was spitting warning for quite some time.
.circleci/config.yml
Outdated
| resource_class: arm.medium | ||
| environment: | ||
| architecture: "arm64" | ||
| platform: "linux/arm64" | ||
|
|
||
| machine_executor_amd64: | ||
| machine: | ||
| image: ubuntu-2004:202201-02 # Ubuntu 20.04, Docker v20.10.12, Docker Compose v1.29.2 | ||
| image: ubuntu-2004:current # https://circleci.com/developer/machine/image/ubuntu-2004 |
There was a problem hiding this comment.
We are using quite an old image, ubuntu-2204 would be better to use
There was a problem hiding this comment.
👍🏼 sure. easy change to make.
usmansaleem
added a commit
to usmansaleem/web3signer
that referenced
this pull request
Apr 13, 2023
This reverts commit 7a2e0de.
usmansaleem
added a commit
that referenced
this pull request
Apr 13, 2023
alexandratran
removed
the
doc-change-required
jframe
pushed a commit
to jframe/web3signer
that referenced
this pull request
Aug 2, 2023
* build.gradle: Java 17 * circleci: Java 17 * build.gradle: removing jdk11 docker tag * changelog * license reporting config: MIT license normalized * Update gatling (performance test) gradle plugin version * CircleCI: Install Java 17 for machine executors * circleci: machine image to use ubuntu-2204:current
jframe
added a commit
to jframe/web3signer
that referenced
this pull request
Aug 4, 2023
This reverts commit 39f09b0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Use Java 17 for build and runtime. Enforce Java 17+ in build.gradle. Use Java 17 in CircleCI config. Remove Java 11 variant of docker.
Fixed Issue(s)
#718
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog