Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non blocking upcheck #904

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Non blocking upcheck #904

merged 2 commits into from
Sep 7, 2023

Conversation

gfukushima
Copy link
Contributor

@gfukushima gfukushima commented Sep 6, 2023 •
edited
Loading

PR Description

This PR removes the usage of the BlockingHandlerDecorator from the upcheck endpoint. This some very particular scenarios can cause the upcheck to stop responding when the worker pool is exhausted.

Fixed Issue(s)

Fixes #891

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

jframe
jframe approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfukushima gfukushima merged commit be75f36 into Consensys:master Sep 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upcheck sometimes blocked by Pruning
2 participants
@gfukushima @jframe