This repository has been archived by the owner on Jul 5, 2021. It is now read-only.
Adding credstash backend #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelasevero
force-pushed
the
backend/credstash
branch
2 times, most recently
from
28e78c9
to
e186b35
Compare
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
===========================================
- Coverage 80.85% 70.55% -10.30%
===========================================
Files 9 10 +1
Lines 350 411 +61
===========================================
+ Hits 283 290 +7
- Misses 53 104 +51
- Partials 14 17 +3
Continue to review full report at Codecov.
|
knelasevero
force-pushed
the
backend/credstash
branch
from
e186b35
to
461657f
Compare
knelasevero
changed the title
|
Just leaving the draft up here. Will get back to it when I have time to write the tests and properly manually try things. I can still get feedback if someone has some 😄 |
knelasevero
changed the title
knelasevero
force-pushed
the
backend/credstash
branch
from
802240e
to
2c1196f
Compare
|
i am going to merge this since it is taking a long time to get merged (my fault 😅 ). After we are confortable with all the backends that got integrated on master we can prepare to launch another release! |
|
/approve |
![paul-the-alien[bot]](https://avatars.githubusercontent.com/in/83809?s=60&v=4){kind=small}
|
/label merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding credstash backend heavily based on ouzi-dev/credstash-operator.