-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
28e78c9
to
e186b35
Compare
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
===========================================
- Coverage 80.85% 70.55% -10.30%
===========================================
Files 9 10 +1
Lines 350 411 +61
===========================================
+ Hits 283 290 +7
- Misses 53 104 +51
- Partials 14 17 +3
Continue to review full report at Codecov.
|
e186b35
to
461657f
Compare
Just leaving the draft up here. Will get back to it when I have time to write the tests and properly manually try things. I can still get feedback if someone has some 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey mate, thanks for this work!
I couldn't test on a real AWS setup, but I left some comments on the code itself ✨
802240e
to
2c1196f
Compare
i am going to merge this since it is taking a long time to get merged (my fault 😅 ). After we are confortable with all the backends that got integrated on master we can prepare to launch another release! |
/approve |
/label merge |
Adding credstash backend heavily based on ouzi-dev/credstash-operator.