Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keys are stored with _tmp and always gives Cache Miss when used in Multi Node Redis Cluster #319

Closed
SouradipPoddar opened this issue Mar 6, 2023 · 3 comments
Closed

Keys are stored with _tmp and always gives Cache Miss when used in Multi Node Redis Cluster #319

SouradipPoddar opened this issue Mar 6, 2023 · 3 comments

Comments

@SouradipPoddar
Copy link
Contributor

We have a setup of a redis cluster with 3 master and 3 replica nodes. We are using CHProxy as a caching layer for our application. Previously we had used the file system type of chproxy. Now we are moving to redis. We can see that all keys are being stored as _tmp. When hitting the same query again, CHProxy gives a cache miss and inserts another record with _tmp suffix.

temp_prefix_snap
SouradipPoddar pushed a commit to SouradipPoddar/chproxy that referenced this issue Mar 6, 2023
@SouradipPoddar7
ContentSquare#319 Fixed Redis Cluster Crossslot Issue
ccdf295
@SouradipPoddar SouradipPoddar mentioned this issue Mar 6, 2023
Merged
13 tasks
@SouradipPoddar
Copy link
Contributor Author

Fix is part of this PR. #320
Awaiting review.

@mga-chka
Copy link
Collaborator

mga-chka commented Mar 6, 2023 •
edited
Loading

can you give the configuration of your chproxy & the setup of your Redis? Because we're using the cache on redis (+ multiple users of chproxy) and it's the first time we see the issue you mentioned.

[edit]: I looked a the description of the PR (and not just the code) and I understand a bit more. See my comments in the PR.

SouradipPoddar pushed a commit to SouradipPoddar/chproxy that referenced this issue Mar 6, 2023
@SouradipPoddar7
Added Comments for the Change ContentSquare#319
4e8edfe
mga-chka pushed a commit that referenced this issue Mar 7, 2023
@SouradipPoddar @SouradipPoddar7
#319 Fixed Redis Cluster Crossslot Issue (#320)
6833740 
* #319 Fixed Redis Cluster Crossslot Issue

* Added Previously Removed Newline

* Removed Extra Introduced Tab

* Added Comments for the Change #319

* Fixed Formatting Issues

---------

Co-authored-by: Souradip Poddar <souradip.poddar@whatfix.com>
@mga-chka
Copy link
Collaborator

mga-chka commented Mar 7, 2023

I'm closing the issue since the PR fixing it is merge.
It will be in the next release that should be available before the end of the month

@mga-chka mga-chka closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mga-chka @SouradipPoddar