fix retrynumber #269
Merged
fix retrynumber #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mga-chka
reviewed
Nov 15, 2022
config/config.go
Outdated
| @@ -39,7 +39,7 @@ var ( | |||
|
|
|||
| defaultMaxPayloadSize = ByteSize(1 << 50) | |||
|
|
|||
| defaultRetryNumber = 0 | |||
| defaultRetryNumber = 1 | |||
There was a problem hiding this comment.
why is the default value to 1? if you do that the behavior of chproxy will change after the update? If yes, it would be better to put it back to 0 then let the chproxy admin choose whether or not the feature should be active
There was a problem hiding this comment.
I agree with @mga-chka. For the sake of test it's enough what you have done in config_test.go
There was a problem hiding this comment.
Fixed @mga-chka , @Garnek20
gontarzpawel
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: rename config retrynumber to retry_number
Pull request type
Please check the type of change your PR introduces:
Checklist
Does this introduce a breaking change?
Further comments