Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

work on getting all the embedded screens from a root screen #3155

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

work on getting all the embedded screens from a root screen #3155

wants to merge 2 commits into from

Conversation

shroffk
Copy link
Member

@shroffk shroffk commented Oct 3, 2024

Not necessarily very happy with the structure of the code and am quite happy for input

georgweiss
georgweiss approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this change add an API to spot all embedded displays, there is still some processing to perform. Patching pv_name in all files is not sufficient, the parent file referencing the embedded display must be updated to reference the patched bob file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgweiss georgweiss georgweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shroffk @georgweiss