-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar entry for Logbook #3163
Conversation
ah this is nice... |
So this preference setting is no longer available? If so that is too bad, we are using that here. |
Ok, Should we in general use Messages for UI representation ( so that we can switch languages )...and what is the role that preferences should play here? |
Oh dear, I was under the impression that only ESS users were unhappy with "Log Entry Table" and wanted a customized name like Logbook. In any case, reason I chose to go for a (potentially localized) string in Messages is that the preference did override the default name, which in turn had an impact on the toolbar customization. See also #3014 for additional aspects of localization and potential remedy. |
It's not a huge deal but I feel like we should be careful about removing preference settings since we can't know who uses them. In our case the phoebus OLOG integration is for a very specific purpose so we use I haven't looked into the Messages property files and how they come into play but see that is how the French UI support is implemented. Is that the recommended way to change specific UI text in phoebus? If so that is fine for us |
Well, changing Messages is actually about changing messages.properties. This is not very flexible. |
I will push a PR addressing the issue mentioned by @tynanford, and and the same time resolve application name localization as dicussed #3014. |
Some additional changes:
Removed option to customize display name for "Log Entry Table" app. The display name is now "Logbook" set in messages.properties file.