Switch to Trio #48
Merged
Switch to Trio #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, we switch to use the Trio asynchronous library alongside httpx instead of using asyncio with aiohttp. My logic for this is, since we already needed aiohttp as a dependency before, we've already broken the try for zero dependencies wall, and I feel that they way Trio handles structured concurrency is a lot nicer. I will say though I'm biased, I am a member of the Trio organization and have been doing a lot over there. But my point stands.
Other than that, this pull request should have no functional changes, other than adding a
py.typedfile I should have added ages ago.