Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember bl integration #8

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

ember bl integration #8

wants to merge 9 commits into from

Conversation

dmezh
Copy link
Member

@dmezh dmezh commented Jun 17, 2023

No description provided.

Copy link
Member

@jacobkoziej jacobkoziej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted small issues if you'd like to fix them. One major inconsistency was having opening curly braces for function definitions inline or on a newline.

Overall great work 😄

Comment on lines +19 to +22
// for (;;) {
// printf("Hello :)\n");
// vTaskDelay(200 / portTICK_PERIOD_MS);
// }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the dead code?


Import("env")

env.Execute("pip3 install -q -r lib/ember/ember-pio-scripts/requirements.txt")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use $PYTHONEXE -m pip here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants