-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember bl integration #8
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted small issues if you'd like to fix them. One major inconsistency was having opening curly braces for function definitions inline or on a newline.
Overall great work 😄
// for (;;) { | ||
// printf("Hello :)\n"); | ||
// vTaskDelay(200 / portTICK_PERIOD_MS); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the dead code?
|
||
Import("env") | ||
|
||
env.Execute("pip3 install -q -r lib/ember/ember-pio-scripts/requirements.txt") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use $PYTHONEXE -m pip
here?
No description provided.