Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify how source buffer is being saved and unify prompt clearing #505

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Simplify how source buffer is being saved and unify prompt clearing #505

merged 1 commit into from
Nov 17, 2024

Conversation

deathbeam
Copy link
Collaborator

  • Instead of passing state.source around, simply update it only if we are outside of chat window and make M.open() noop otherwise
  • Unify when last prompt is cleared, clear it in .ask always instead of doing it only when explicitely submitting prompt

@deathbeam deathbeam added the enhancement New feature or request label Nov 17, 2024
@deathbeam
Simplify how source buffer is being saved and unify prompt clearing
28c8072 
- Instead of passing state.source around, simply update it only if we are
  outside of chat window and make M.open() noop otherwise
- Unify when last prompt is cleared, clear it in .ask always instead of
  doing it only when explicitely submitting prompt
- Unify how selection is checked when simply showing it

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
@deathbeam deathbeam merged commit 33c350e into CopilotC-Nvim:canary Nov 17, 2024
1 check passed
@deathbeam deathbeam deleted the improve-stability branch November 17, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deathbeam