Test with Xcode 14.0 and Swift 5.7 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
reviewed
Aug 24, 2022
| `<blah ` | ||
| """) | ||
| if #available(iOS 16.0, tvOS 16.0, macOS 13.0, *) { | ||
| XCTAssertEqual(ctx.debugDescription, column7) |
There was a problem hiding this comment.
Do we (want to) guarantee error output from Foundation? If so, this PR alone seems to indicate we cannot.
There was a problem hiding this comment.
This output seemed to be pretty stable up to this point, and I haven't found a different way to test the error context functionality end-to-end without being exposed to these caveats with how Foundation handle this.
Joannis
approved these changes
Aug 25, 2022
|
Thanks, I've created #248 to track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the XML parser from Foundation treats errors differs between SDK versions, we have to handle this in our tests accordingly.