Clean up coding logic, reducing hard to maintain code duplication; improve box naming #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 48.66% 50.55% +1.89%
==========================================
Files 28 28
Lines 1644 1351 -293
==========================================
- Hits 800 683 -117
+ Misses 844 668 -176
Continue to review full report at Codecov.
|
MaxDesiatov
requested changes
Dec 21, 2018
What’s interesting about `ArrayBox` is its unkeyed semantics, not the fact it’s currently using an `Array` as storage, which is an implementation detail after all.
What’s interesting about `DictionaryBox` is its keyed semantics, not the fact it’s currently using an `Dictionary` as storage, which is an implementation detail after all, and expected to be changed soon, even (to preserve element order).
|
Should be ready to merge now. 🙂 |
MaxDesiatov
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.