Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve XMLStackParserTests to test against CDATA blocks #51

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Improve XMLStackParserTests to test against CDATA blocks #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77bad68
Improve `XMLStackParserTests` to test against CDATA blocks
regexident Jan 2, 2019
75ef78b
Merge branch 'master' into fix/cddata-tests
hodovani Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Tests/XMLCoderTests/Auxiliary/XMLStackParserTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@ class XMLStackParserTests: XCTestCase {
func testParseWith() throws {
let parser = _XMLStackParser()

let xmlString = "<container><value>42</value></container>"
let xmlString =
"""
<container>
<value>42</value>
<data><![CDATA[lorem ipsum]]></data>
</container>
"""
let xmlData = xmlString.data(using: .utf8)!

let root: _XMLElement? = try parser.parse(with: xmlData,
Expand All @@ -27,6 +33,12 @@ class XMLStackParserTests: XCTestCase {
value: "42"
),
],
"data": [
_XMLElement(
key: "data",
value: "lorem ipsum"
),
],
]
)
XCTAssertEqual(root, expected)
Expand Down