Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the possibility to disable all quotes in a csv file #1

Merged
merged 3 commits into from
Sep 12, 2018

Conversation

akeromnes
Copy link
Contributor

remove all quotes of a csv file if needed.

@coveralls
Copy link

coveralls commented Aug 23, 2018

Coverage Status

Coverage increased (+0.03%) to 86.976% when pulling d12a355 on akeromnes:master into 675acdb on Coreoz:master.

@amanteaux
Copy link
Member

Thank you for your contribution!

In your change you are using the method CSVWriter.(nextLine, applyQuotesToAll). So actually, if you set the applyQuotesToAll to false, that does not mean that the CSV file won't contain any quote, it means that if a value does not contain any special characters (quote, escape, separator, newline, or return), then this value will not be wrapped with quotes.
Is that the intended behavior of your pull request?

@akeromnes
Copy link
Contributor Author

Yes it's exactly that, disable wrapping quotes.

@amanteaux
Copy link
Member

Just to be really sure of the behavior you implemented:

  • the value 123 will be rendered with 123: so no quotes
  • the value 123,2 will be rendered with "123,2": so quotes are displayed since they are mandatory in this case

Is this ok?

@akeromnes
Copy link
Contributor Author

Yes this is the intended behavior.

@amanteaux amanteaux merged commit e1db3e4 into Coreoz:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants