Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan package #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conan package #197

wants to merge 1 commit into from

Conversation

half2me
Copy link

@half2me half2me commented Mar 28, 2017

Having the ability to install this via Conan would be awesome.
I starting working on a conanfile, but this is in no way complete. I was hoping someone with more experience could help me set this up, and it could be added to the project in the future?
I'll keep on working on this in the meantime...

@nunojpg
Copy link
Contributor

nunojpg commented Apr 16, 2017

I'm also doing some work on this. I hope I can provide a pull request this week for suggestions/improvements and also include the package generation on CI.

@ben-crowhurst
Copy link
Member

ben-crowhurst commented Apr 19, 2017

@half2me if you're willing to maintain this entry we will welcome the inclusion.

Please place the file within a script folder as I have a feeling will see a flood of these.

Ok?

@nunojpg
Copy link
Contributor

nunojpg commented Apr 23, 2017

@half2me take a look at my implementation at https://github.com/nunojpg/conan-restbed

  • I also did a ASIO package that this restbed package depends on. OpenSSL already existed and the rest we use the compile bundled dependencies.
  • Currently conan build system is beta and the syntax had breaking changes for example this week. I would suggest to try to leave it stagging for some time, and when it becomes stable for a few months, maybe @ben-crowhurst can consider making the CI build to a Corvusoft channel on conan.io.

It would also be nice if we can make Windows CI to work. If not AppVeyor maybe using Visual Studio Team Services.

@half2me
Copy link
Author

half2me commented Apr 24, 2017

@nunojpg great idea. I have no experience with conan, so I doubt I'll be able to help much, I was mainly trying to give incentive :D

@nunojpg
Copy link
Contributor

nunojpg commented May 12, 2017

@ben-crowhurst as a side-effect of this conan packaging effort, restbed is compiling fine on Appveyor.

https://ci.appveyor.com/project/nunojpg/conan-restbed

I don't know much about Windows builds or appveyor, so I can't understand what is causing the trouble with appveyor (#81).

What I can say is that I am using the absolute default cmake build, without any kind of hacks for windows.

@ben-crowhurst
Copy link
Member

ben-crowhurst commented May 13, 2017

Is any further work required? Or should I just merge this PR?

@nunojpg
Copy link
Contributor

nunojpg commented May 13, 2017

This recipe is not compatible with Windows. For me is NOK. If you feel Conan is important (and eventually you'll will :)), then I can PR a much more complete recipe with continuos integrations builds. The problem is that you still have to create a Corvusoft channel and this package maintenance maybe should be offloaded to the community. One option is to leave it unofficial, the other is to create a repo and give some people commit privileges to it.

@ben-crowhurst
Copy link
Member

A community led effort would be desirable. How do you want me to proceed?

@nunojpg
Copy link
Contributor

nunojpg commented May 15, 2017

I ask for more 1 week to further test my conan package implementation, and then I'll suggest a way forward.

@nunojpg
Copy link
Contributor

nunojpg commented Jun 23, 2017

Hi, sorry for the delay. Conan just changed their repository model and now provide very specific instructions on the recommended uniform packaging approach.

http://docs.conan.io/en/latest/packaging/bintray/conan_center_guide.html

They also provide some new quality requirements, and I don't meet them all yet.

So I need about 2 more weeks to get back to this. Then I suggest you fork my repository to make it Corvusoft "official" and for any future changes I'll pull request your repository.

@Croydon Croydon mentioned this pull request Feb 1, 2019
@Croydon
Copy link

Croydon commented Nov 4, 2019

Conan has a new central repository for maintaining recipes and getting them into Conan Center (the official Conan repository)

I'm recommending to get a recipe for restbed in there: https://github.com/conan-io/conan-center-index/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants