-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie parsing and "path parameters" #309
Open
CheyenneForbes
wants to merge
19
commits into
Corvusoft:master
Choose a base branch
from
AvapnoFoundation:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a vector instead of a set for m_paths to keep the insert order
Any "path" after a path parameter matcher with "TO_END" as its value will be considered a part of the path parameter
CheyenneForbes
changed the title
Allow full paths to be parameters
Allow full paths to be parameters and cookies to be parsed
Jun 1, 2018
CheyenneForbes
changed the title
Allow full paths to be parameters and cookies to be parsed
Cookie parsing and "path parameters"
Jun 1, 2018
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full paths
This will come in handy in cases where a developer wants to serve static files from a folder (css, etc.).
Here is the syntax:
static_resource->set_path( "/static/{filepath: TO_END}" );
static_resource->set_paths( {"/{filepath: TO_END}", "/static/{filepath: TO_END}"} );
Only 1 "TO_END" parameter can be used per path
Cookies
request->get_cookie_parameter("my-value");
request->get_cookie_parameters();