Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to generate separate JSON schema files #1478

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Nov 7, 2022

Closes #1476

I didn't add clap as a dep here since it felt like overkill, but it can be integrated in the future if these binaries become more complicated.

@uint uint force-pushed the separate-schema-files branch from 10bad92 to c2aceab Compare November 8, 2022 11:17
println!(" --help");
println!(" Print this helpfile.");
return;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Souldn't this code live somewhere in the CLI code (close to some main function)? write_api_impl should take the switch as an argument.

I guess the issue is that the contract developer owns the binaries. Maybe we should change that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be super cool if cargo schema was a binary you install with cargo install, but I get the feeling that wouldn't be so easy to do

@uint uint force-pushed the separate-schema-files branch from c2aceab to c3e1169 Compare November 21, 2022 23:37
@uint uint force-pushed the separate-schema-files branch from c3e1169 to afc2a7e Compare November 21, 2022 23:44
@uint
Copy link
Contributor Author

uint commented Nov 21, 2022

Rebased and applied suggestion from #1476 (comment)

@uint uint requested a review from webmaster128 November 21, 2022 23:48
@webmaster128 webmaster128 merged commit 89cfede into main Nov 22, 2022
@webmaster128 webmaster128 deleted the separate-schema-files branch November 22, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to export raw JSON Schema files
2 participants