Float support #1864
Merged
Float support #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
commented
Sep 14, 2023
chipshort
force-pushed
the
1845-float-support
branch
from
c74d1ae to
3140928
Compare
webmaster128
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Great stuff! Some more small findings.
What I think we should add now:
- CHANGELOG entry
- Port the test to wasmvm, allowing for easier testing in more systems
- A second review by e.g. @DariuszDepta
chipshort
force-pushed
the
1845-float-support
branch
from
c52d47c to
8ad8948
Compare
DariuszDepta
approved these changes
Sep 25, 2023
chipshort
force-pushed
the
1845-float-support
branch
from
72b3625 to
5538397
Compare
This was referenced Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1845
functionality itself is implemented
I replaced the floaty contract with one that can execute any wasm float instruction.