Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Make CacheOptions non-exhaustive #1898

Merged
merged 2 commits into from
Oct 18, 2023
Merged

[2.0] Make CacheOptions non-exhaustive #1898

merged 2 commits into from
Oct 18, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1702

webmaster128
webmaster128 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Just a CHANGELOG entry

@chipshort chipshort force-pushed the 1702-cacheoptions-non-exhaustive branch from e3f2f37 to 498aa99 Compare October 18, 2023 09:39
@chipshort chipshort merged commit 6e7b1e6 into main Oct 18, 2023
3 checks passed
@chipshort chipshort deleted the 1702-cacheoptions-non-exhaustive branch October 18, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make CacheOptions non-exhaustive and add unchecked module loading
2 participants
@chipshort @webmaster128