Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove interface version 7 support #1952

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Remove interface version 7 support #1952

merged 2 commits into from
Nov 20, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1950

webmaster128
webmaster128 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a CHANGELOG

packages/vm/Cargo.toml
@@ -64,7 +59,7 @@ bitflags = "1.1.0" # https://github.com/CensoredUsername/dynasm-rs/pull/74
# wasmer-middlewares = { path = "../../../wasmer/lib/middlewares" }

[dev-dependencies]
criterion = { version = "0.4", features = [ "html_reports" ] }
criterion = { version = "0.4", features = ["html_reports"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you get all those toml formatting changes from? Looks like some tool. Let's ensure we use the same.

Copy link
Collaborator Author

@chipshort chipshort Nov 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is caused by the "Even Better TOML" vscode extension. I was using "Better TOML" before, but that's no longer maintained.

@chipshort chipshort force-pushed the remove-allow-interface-7 branch from 3743684 to 58791c5 Compare November 20, 2023 12:24
@chipshort chipshort merged commit 888552a into main Nov 20, 2023
24 of 27 checks passed
@chipshort chipshort deleted the remove-allow-interface-7 branch November 20, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove allow_interface_version_7
2 participants
@chipshort @webmaster128