Add QueryRequest::Grpc
#1973
Merged
Add QueryRequest::Grpc
#1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's deprecate it. The migration is not fully trivial since the contract needs to change the decoding from JSON to protobuf. It's a bit nicer to give people time for that. |
chipshort
force-pushed
the
1966-grpc-query
branch
from
cce99ef
to
58f751c
Compare
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
chipshort
force-pushed
the
1966-grpc-query
branch
from
58f751c
to
e1aa326
Compare
webmaster128
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1966
Do we also want to remove / deprecate the Stargate query? Only on the contract side ofc, since we need to continue supporting it in wasmd for 1.x compatibility.