Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive query to hackatom #494

Merged
merged 7 commits into from
Jul 23, 2020
Merged

Conversation

ethanfrey
Copy link
Member

Closes #492

Adds a recursive query with adjustable depth and adjustable work-factor.

This will allow us to add wasmd unit tests on query recursion limits: CosmWasm/wasmd#212
and better enforcing gas limits on recursive queries: #456

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Can you update vm's "sha2" to 0.9 to avoid multiple sha2 dependencies?

contracts/hackatom/src/contract.rs Outdated Show resolved Hide resolved
contracts/hackatom/src/contract.rs Show resolved Hide resolved
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the lockfiles of the other contracts are probably outdated. See contract/Step 1 at https://github.com/CosmWasm/cosmwasm/blob/master/README.md#developing how to update in one command

@ethanfrey
Copy link
Member Author

I'm updating it now...

@ethanfrey ethanfrey merged commit 74781c5 into master Jul 23, 2020
@ethanfrey ethanfrey deleted the add-recursive-query-to-hackatom branch July 23, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add recursive self-query to hackatom contract
2 participants