Cache Artifacts directly instead of their serialization #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
cache-artifact-not-module
branch
from
bbed9cf to
5996df1
Compare
3 tasks
webmaster128
force-pushed
the
cache-artifact-not-module
branch
from
5996df1 to
b2bce53
Compare
webmaster128
force-pushed
the
update-wasmer
branch
from
68866de to
b7110d1
Compare
webmaster128
force-pushed
the
cache-artifact-not-module
branch
from
b2bce53 to
a428d83
Compare
ethanfrey
reviewed
Dec 16, 2020
| let store = make_store_headless(Some(memory_limit)); | ||
| let new_module = unsafe { Module::deserialize(&store, &serialized_artifact) }?; | ||
| let new_module = Module::from_artifact(&store, Arc::clone(artifact)); |
There was a problem hiding this comment.
Nice, we just update reference count, clone is super cheap
webmaster128
changed the title
|
Updated title and description, as this was outdated. |
webmaster128
force-pushed
the
cache-artifact-not-module
branch
from
a428d83 to
355da47
Compare
webmaster128
force-pushed
the
cache-artifact-not-module
branch
from
355da47 to
0d1c158
Compare
webmaster128
changed the base branch from
master
to
upgrade-wasmer-santa-edition
webmaster128
force-pushed
the
cache-artifact-not-module
branch
2 times, most recently
from
7916272 to
966493b
Compare
webmaster128
force-pushed
the
upgrade-wasmer-santa-edition
branch
from
82c5be5 to
8703431
Compare
webmaster128
force-pushed
the
cache-artifact-not-module
branch
from
966493b to
f868f12
Compare
|
This cannot work, see wasmerio/wasmer#1943 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ths creates a new store for every instance. This is needed for metering as well as consistency with file system cache.