Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub calls and entry point #796

Merged
merged 16 commits into from
Mar 1, 2021
Merged

Sub calls and entry point #796

merged 16 commits into from
Mar 1, 2021

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Feb 24, 2021 •
edited
Loading

Closes #691

  • Add std entry point and subcall types
  • Update response type
  • Fix all broken tests
  • Add support to reflect contract
  • Unit/integration test reflect contract
  • Update CHANGELOG
  • Rebuild test contract

@ethanfrey ethanfrey force-pushed the sub-calls-and-entry-point branch 2 times, most recently from f7b7b88 to 1e8294b Compare February 24, 2021 22:10
@ethanfrey ethanfrey marked this pull request as ready for review February 24, 2021 22:10
@ethanfrey
Copy link
Member Author

This should be fully implemented based on our discussion on the issue. Happy for any change requests on the actual types sent, but even more on the naming. I think the names are descriptive enough, but feel rather long and awkward to me.

("sub call" is a more common usage than "subcall", so I camel-cased it as SubCall)

This was referenced Feb 26, 2021
Closed
Closed
Closed
webmaster128
webmaster128 reviewed Mar 1, 2021
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Basically just the renaming we talked about

contracts/burner/src/contract.rs Show resolved Hide resolved
contracts/reflect/src/msg.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
contracts/reflect/src/contract.rs Outdated Show resolved Hide resolved
contracts/reflect/src/state.rs Outdated Show resolved Hide resolved
packages/std/src/exports.rs Outdated Show resolved Hide resolved
packages/std/src/results/subcall.rs Outdated Show resolved Hide resolved
packages/vm/src/calls.rs Outdated Show resolved Hide resolved
packages/vm/src/calls.rs Outdated Show resolved Hide resolved
packages/vm/src/testing/calls.rs Outdated Show resolved Hide resolved
@ethanfrey ethanfrey force-pushed the sub-calls-and-entry-point branch from 70468d6 to 84f8fb1 Compare March 1, 2021 12:30
@ethanfrey
Copy link
Member Author

Rebased, made all requested changes, and rebuilt test contract.

Let me know if this is good to merge now?

webmaster128
webmaster128 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@webmaster128 webmaster128 merged commit c7bdef9 into main Mar 1, 2021
@webmaster128 webmaster128 deleted the sub-calls-and-entry-point branch March 1, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "SubCall" to get result from a message
2 participants
@ethanfrey @webmaster128