Secondary index composite key #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
commented
Dec 21, 2020
| let mut store = MockStorage::new(); | ||
| let mut map = build_map(); | ||
|
|
||
| // save data |
There was a problem hiding this comment.
I would pull this out into a setup function as I see this in 3 tests or so.
|
|
||
| /// MARKER is stored in the multi-index as value, but we only look at the key (which is pk) | ||
| const MARKER: u32 = 1; | ||
| // FIXME: Re-introduce this for MultiIndex | ||
| // const MARKER: bool = true; |
There was a problem hiding this comment.
Where did this go?
btw, I used 1u32 as it has the smallest json representation (1 vs true)
There was a problem hiding this comment.
I did this to make prefix() work. prefix() returns Prefix<T>, so I needed the value type to match.
That said, this is just temporary, and towards a solution.
|
Closing in favour of #211. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @maurolacy so I can comment
After discussion, this is either very difficult or impossible with current API and encoding schemes.
We may need to differentiate VarLength indexes and FixedLength indexes