Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use signext lowering in wasm-opt #128

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Use signext lowering in wasm-opt #128

merged 6 commits into from
Jul 28, 2023

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Jul 28, 2023 •
edited
Loading

Closes #127.

Updates to binaryen v114 and Rust 1.71.0.

This results in slightly bigger (1/2%) binaries compared to the current version with binaryen v110 and Rust v1.69.0 (and no signext lowering).

@maurolacy maurolacy requested a review from webmaster128 July 28, 2023 07:18
@maurolacy maurolacy changed the title Update binaryen and Rust to latest stable Use signext lowering in wasm-opt Jul 28, 2023
@maurolacy maurolacy force-pushed the update-binaryen-rust branch from 1512dd7 to 79663f2 Compare July 28, 2023 07:58
webmaster128
webmaster128 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

I suggest a comment to the wasm-opt calls along the lines of
--signext-lowering is needed to support blockchain runnning CosmWasm < 1.3. It can be removed eventually

CHANGELOG.md Outdated Show resolved Hide resolved
maurolacy and others added 2 commits July 28, 2023 11:53
@maurolacy @webmaster128
Fix typo
ed0ef8a 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@maurolacy
Add signext-lowering comment
bc393ba
@maurolacy maurolacy merged commit 35ee4b2 into main Jul 28, 2023
@maurolacy maurolacy deleted the update-binaryen-rust branch July 28, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use --signext-lowering and upgrade Rust to 1.71
2 participants
@maurolacy @webmaster128