Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: wasm files target path #46

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Fix: wasm files target path #46

merged 1 commit into from
Apr 22, 2021

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Apr 22, 2021 •
edited
Loading

Fix the target path for *.wasm files in workspace-optimizer.

This also fixes cosmasm-plus #273.

Update: Will revert the change of shells in another PR, along with changing the echo -ns

@maurolacy maurolacy requested a review from webmaster128 April 22, 2021 08:20
webmaster128
webmaster128 reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a section to the 0.11.2 CHANGELOG about this fix?

@maurolacy
Copy link
Contributor Author

Looks good. Can you add a section to the 0.11.2 CHANGELOG about this fix?

Sure. Let's do it in main directly, as this is an outdated branch.

@webmaster128 webmaster128 merged commit 4fb745e into main Apr 22, 2021
@webmaster128 webmaster128 deleted the optimizers-shell branch April 22, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build_and_upload_contract CI job fails
2 participants
@maurolacy @webmaster128