Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version subcommand does not work #24

Closed
4 tasks
clevinson opened this issue Jan 14, 2020 · 5 comments
Closed
4 tasks

version subcommand does not work #24

clevinson opened this issue Jan 14, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@clevinson
Copy link

clevinson commented Jan 14, 2020

Summary of Bug

wasmd version does not work.

Output is currently a blank newline whenever running wasmd version. Seems like this the correct subcommand though, as wasmd --version returns an "unknown flag" error and trying something like wasmd verssion outputs:

ERROR: unknown command "verssion" for "wasmd"

Did you mean this?
	version

Version

git commit hash: ce35d8d

Steps to Reproduce

make install
wasmd version

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@clevinson clevinson added the bug Something isn't working label Jan 14, 2020
@clevinson
Copy link
Author

Seems to pull in version logic from this submodule: https://github.com/cosmos/cosmos-sdk/tree/master/version

I tried looking in cosmos-sdk repo to see if this was a known issue that has already been fixed, but couldn't find anything.

@ethanfrey
Copy link
Member

Ah, yes, this needs to be set in the Makefile when building.

I don't know why it defaults to empty rather than git commit.
Valid issue

@sahith-narahari
Copy link
Contributor

I think there's no valid tag and hence the empty response.
Pushing a tag 0.0.0 should solve this or alternatively replacing git describe --tags with git describe --always in this line will give commit hash as response https://github.com/cosmwasm/wasmd/blob/b2086bb6b40ca74a3959927ca7219bfe0b60c7d9/Makefile#L4

@ethanfrey
Copy link
Member

Good to know.
There will be a 0.6.0 tag within a day or so, so let's see see if this fixes the issue

@ethanfrey
Copy link
Member

There will be a 0.6.0 tag within a day or so, so let's see see if this fixes the issue

🤦‍♂️ delays and more delays on 0.38.0...

I have been tagging pre-release versions and wasmd version now reads: 0.0.3-4-ge4be8f1. Case closed.

loloicci pushed a commit to loloicci/wasmd that referenced this issue Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants