Get Contracts by Creator Address #1021

vuong177 · 2022-09-23T18:30:20Z

Closes : #998

What in this PR:

Add a new index for getting contracts by creator address.
Create a migration to build the initial index.

x/wasm/keeper/keeper.go

jhernandezb · 2022-09-24T03:20:31Z

We need to provide a migration for this so that chains upgrading can build the initial index.

codecov · 2022-09-25T05:59:26Z

Codecov Report

Merging #1021 (6828aa2) into main (9858034) will decrease coverage by 0.03%.
The diff coverage is 57.30%.

@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
- Coverage   59.29%   59.25%   -0.04%     
==========================================
  Files          52       53       +1     
  Lines        6630     6718      +88     
==========================================
+ Hits         3931     3981      +50     
- Misses       2408     2442      +34     
- Partials      291      295       +4

Impacted Files	Coverage Δ
x/wasm/client/cli/query.go	`0.00% <0.00%> (ø)`
x/wasm/module.go	`37.90% <60.00%> (+0.40%)`	⬆️
x/wasm/keeper/keeper.go	`87.40% <71.42%> (-0.36%)`	⬇️
x/wasm/keeper/querier.go	`72.32% <90.00%> (+1.73%)`	⬆️
x/wasm/keeper/migrations.go	`100.00% <100.00%> (ø)`
x/wasm/types/keys.go	`60.71% <100.00%> (+9.60%)`	⬆️

vuong177 · 2022-09-25T08:22:14Z

We need to provide a migration for this so that chains upgrading can build the initial index.

I'm going to make this. Thanks for your suggestion.
.

alpe

Thanks a lot for driving this forward. 👏 🏄
It looks very good already! Just some minor comments that should be easy to address!

x/wasm/client/cli/query.go

x/wasm/keeper/genesis_test.go

x/wasm/keeper/keeper.go

x/wasm/module.go

x/wasm/types/exported_keepers.go

x/wasm/types/keys.go

x/wasm/types/keys_test.go

x/wasm/keeper/keeper.go

alpe · 2022-09-27T11:07:50Z

x/wasm/keeper/migrations.go

+		m.keeper.addToContractCreatorThirdIndex(ctx, creator, contractAddress)
+	}
+	return nil
+}


A test for the migration is required.

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>

vuong177 · 2022-09-27T16:08:34Z

@alpe thanks for the clear suggestions. I'm making it

alpe

Good progress and tests. Thanks for your contribution! 💐
Still some changes are mandatory. No rush. I would let you handle this but please let me know if you don't have enough capacity or want somebody to jump in.

x/wasm/keeper/keeper.go

x/wasm/keeper/keeper_test.go

x/wasm/keeper/migrations.go

vuong177 · 2022-09-28T08:25:11Z

I made this PR to draft and will be ready when I complete your suggested change. Thank you again, @alpe, I learned many things from your reviews.

x/wasm/keeper/querier.go

alpe · 2022-09-29T09:28:37Z

x/wasm/types/keys.go

@@ -51,7 +51,8 @@ func GetContractAddressKey(addr sdk.AccAddress) []byte {

 // GetContractsByCreatorPrefix returns the contracts by creator prefix for the WASM contract instance
 func GetContractsByCreatorPrefix(addr sdk.AccAddress) []byte {
-	return append(ContractsByCreatorPrefix, addr...)
+	bz := address.MustLengthPrefix(addr)


👍 thanks!

* main: Bump actions/checkout from 3.0.2 to 3.1.0 Revert module version to 1 as there is no migration Doc ante handler Fix: typos

alpe · 2022-10-20T17:05:20Z

Thanks a log for your work on this. This was really helping. 💯

* add query to query.proto * add ContractsByCreatorPrefix in keys.go * add ContractCreatorThirdIndex to keeper.go * add querier * cli * fix test * linting * add key test * no need to change creator when migrate * add query test * minor * add migrate logic * add more test * register migration * minor * Update x/wasm/client/cli/query.go Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> * nits * remove IterateAllContract * Update x/wasm/keeper/genesis_test.go Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> * nit * nit: func name * change key * improve TestIteratorContractByCreator * fix test * use IterateContractInfo in migrate2to3 * minor * move key * improve test case * add pagReq in ContractsByCreator query * ordering query * add migrate test * Make ContractsByCreator plural; formatting and minor updates * Comment why AbsoluteTxPositionLen makes sense * Migrate 1 to 2 * Set module version Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com>

vuong177 added 5 commits September 24, 2022 00:22

add query to query.proto

0473927

add ContractsByCreatorPrefix in keys.go

0c628d2

add ContractCreatorThirdIndex to keeper.go

8e40535

add querier

6fd112a

cli

f324e42

github-advanced-security bot found potential problems Sep 23, 2022

View reviewed changes

x/wasm/keeper/keeper.go Fixed Show fixed Hide fixed

vuong177 added 2 commits September 24, 2022 16:34

fix test

21e5ca4

linting

fa51c0d

vuong177 added 4 commits September 25, 2022 14:30

add key test

f856dc3

no need to change creator when migrate

be53b48

add query test

94c0dbf

minor

e0a7384

vuong177 added 4 commits September 25, 2022 16:06

add migrate logic

46b58b7

add more test

f4cfbe8

register migration

c871915

minor

6bfeb16

vuong177 marked this pull request as ready for review September 25, 2022 10:50

vuong177 requested a review from alpe as a code owner September 25, 2022 10:50

alpe suggested changes Sep 27, 2022

View reviewed changes

alpe reviewed Sep 27, 2022

View reviewed changes

x/wasm/keeper/keeper.go Outdated Show resolved Hide resolved

alpe reviewed Sep 27, 2022

View reviewed changes

vuong177 and others added 6 commits September 27, 2022 18:12

Update x/wasm/client/cli/query.go

86692b5

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>

nits

ffbbdf1

remove IterateAllContract

fd757f2

Update x/wasm/keeper/genesis_test.go

a8c9e34

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>

nit

54f157d

nit: func name

df06994

vuong177 added 3 commits September 27, 2022 23:33

change key

93e79f5

improve TestIteratorContractByCreator

2b732cf

fix test

79d6ff6

alpe suggested changes Sep 28, 2022

View reviewed changes

vuong177 added 3 commits September 28, 2022 14:45

use IterateContractInfo in migrate2to3

0a800f6

minor

86e2f54

move key

247487f

vuong177 marked this pull request as draft September 28, 2022 08:25

alpe added this to the v0.30.0 milestone Sep 28, 2022

vuong177 added 2 commits September 28, 2022 18:57

improve test case

f9a53f2

add pagReq in ContractsByCreator query

c4136b5

github-advanced-security bot found potential problems Sep 28, 2022

View reviewed changes

x/wasm/keeper/querier.go Fixed Show fixed Hide fixed

alpe reviewed Sep 29, 2022

View reviewed changes

vuong177 added 2 commits September 29, 2022 23:24

ordering query

b6241b3

add migrate test

c060045

vuong177 marked this pull request as ready for review September 30, 2022 10:32

alpe added 5 commits October 6, 2022 12:55

Make ContractsByCreator plural; formatting and minor updates

dfbdfc2

Comment why AbsoluteTxPositionLen makes sense

fd39267

Migrate 1 to 2

5aa7d1c

Merge branch 'main' into 1021_polished

a05e447

* main: Bump actions/checkout from 3.0.2 to 3.1.0 Revert module version to 1 as there is no migration Doc ante handler Fix: typos

Set module version

52ee675

alpe mentioned this pull request Oct 6, 2022

PR1021 polished - do not merge #1037

Closed

Merge branch 'main' into contractsbycrator

6828aa2

alpe merged commit 6d67d5b into CosmWasm:main Oct 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get Contracts by Creator Address #1021

Get Contracts by Creator Address #1021

vuong177 commented Sep 23, 2022 •

edited

Loading

jhernandezb commented Sep 24, 2022

codecov bot commented Sep 25, 2022 •

edited

Loading

vuong177 commented Sep 25, 2022 •

edited

Loading

alpe left a comment

alpe Sep 27, 2022

vuong177 commented Sep 27, 2022

alpe left a comment

vuong177 commented Sep 28, 2022

alpe Sep 29, 2022

alpe commented Oct 20, 2022

Get Contracts by Creator Address #1021

Get Contracts by Creator Address #1021

Conversation

vuong177 commented Sep 23, 2022 • edited Loading

jhernandezb commented Sep 24, 2022

codecov bot commented Sep 25, 2022 • edited Loading

Codecov Report

vuong177 commented Sep 25, 2022 • edited Loading

alpe left a comment

Choose a reason for hiding this comment

alpe Sep 27, 2022

Choose a reason for hiding this comment

vuong177 commented Sep 27, 2022

alpe left a comment

Choose a reason for hiding this comment

vuong177 commented Sep 28, 2022

alpe Sep 29, 2022

Choose a reason for hiding this comment

alpe commented Oct 20, 2022

vuong177 commented Sep 23, 2022 •

edited

Loading

codecov bot commented Sep 25, 2022 •

edited

Loading

vuong177 commented Sep 25, 2022 •

edited

Loading