Bump version go to 1.19 #1044

GNaD13 · 2022-10-09T15:33:03Z

alpe · 2022-10-10T15:40:43Z

Thanks for the PR! This was quicker than planned. Bumping to 1.19 means chains importing the module would also have to upgrade.
For Context: cosmos/cosmos-sdk#13373 (comment)

GNaD13 · 2022-10-16T11:55:44Z

Thanks for the PR! This was quicker than planned. Bumping to 1.19 means chains importing the module would also have to upgrade. For Context: cosmos/cosmos-sdk#13373 (comment)

Got it. Thanks for your review!!

alpe · 2022-11-11T09:12:43Z

Let's do the upgrade in v0.31 which is getting closer

alpe · 2022-11-17T17:42:51Z

@GNaD13 can you open the PR again, please? We want this for v0.30 after the recent issue on a mainnet

alpe · 2022-11-17T17:43:25Z

CHANGELOG.md

@@ -11,7 +11,7 @@
 - Allow AccessConfig to use a list of addresses instead of just a single address [\#945](https://github.com/CosmWasm/wasmd/issues/945)
 - Make contract addresses predictable \("deterministic"\) [\#942](https://github.com/CosmWasm/wasmd/issues/942)
 - Add query for the total supply of a coin [\#903](https://github.com/CosmWasm/wasmd/pull/903) ([larry0x](https://github.com/larry0x))
- Upgrade go to v1.18 [\#866]https://github.com/CosmWasm/wasmd/pull/866/) ([faddat](https://github.com/faddat))
+- Upgrade go to v1.19 [\#866]https://github.com/CosmWasm/wasmd/pull/866/) ([faddat](https://github.com/faddat))


Please add a new line on top

I have resolved this. Tysm :3

alpe · 2022-11-17T17:43:36Z

README.md

@@ -13,7 +13,7 @@ This code was forked from the `cosmos/gaia` repository as a basis and then we ad
 many gaia-specific files. However, the `wasmd` binary should function just like `gaiad` except for the
 addition of the `x/wasm` module.

-**Note**: Requires [Go 1.18+](https://golang.org/dl/)
+**Note**: Requires [Go 1.19+](https://golang.org/dl/)


alpe · 2022-11-17T17:43:52Z

go.mod

@@ -1,6 +1,6 @@
 module github.com/CosmWasm/wasmd

-go 1.18
+go 1.19


GNaD13 · 2022-11-17T18:08:14Z

@GNaD13 can you open the PR again, please? We want this for v0.30 after the recent issue on a mainnet

Yeah, I got it :3

codecov · 2022-11-17T18:10:29Z

Codecov Report

Merging #1044 (d4b3868) into main (81a5154) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
- Coverage   59.82%   59.79%   -0.03%     
==========================================
  Files          54       54              
  Lines        7273     7273              
==========================================
- Hits         4351     4349       -2     
- Misses       2611     2612       +1     
- Partials      311      312       +1

Impacted Files	Coverage Δ
x/wasm/keeper/keeper.go	`87.40% <0.00%> (-0.32%)`	⬇️

alpe · 2022-11-18T11:31:23Z

Thanks a lot! 👍

* bump go 1.19 * add change log * correct change log

…proposal message (#1072) * Provide source, builder and codehash information in store code proposal message * Make linter happy * Update x/wasm/simulation/proposals.go Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> * Update x/wasm/client/cli/gov_tx.go * Update x/wasm/client/cli/gov_tx.go * Bump github.com/cosmos/gogoproto from 1.4.2 to 1.4.3 Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/cosmos/gogoproto/releases) - [Changelog](https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md) - [Commits](cosmos/gogoproto@v1.4.2...v1.4.3) --- updated-dependencies: - dependency-name: github.com/cosmos/gogoproto dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update authz grant examples * Enable larger wasm bytecode upload for gov proposals (#1095) * Enable larger wasm bytecode upload for gov proposals * Set max proposal wasm code size to 3MB * Bump SDK to v0.45.11 * Fix license head * Fix README header * Bump version go to 1.19 (#1044) * bump go 1.19 * add change log * correct change log * Provide source, builder and codehash information in store code proposal message * Implement source, builder, code_info for StoreAndInstantiateProposal * Apply review recommendations * Make linter happy * Fix tests * Formatting only Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlos Salas <giansalex@gmail.com> Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com> Co-authored-by: GNaD13 <89174180+GNaD13@users.noreply.github.com>

* bump go 1.19 * add change log * correct change log

…proposal message (CosmWasm#1072) * Provide source, builder and codehash information in store code proposal message * Make linter happy * Update x/wasm/simulation/proposals.go Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> * Update x/wasm/client/cli/gov_tx.go * Update x/wasm/client/cli/gov_tx.go * Bump github.com/cosmos/gogoproto from 1.4.2 to 1.4.3 Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/cosmos/gogoproto/releases) - [Changelog](https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md) - [Commits](cosmos/gogoproto@v1.4.2...v1.4.3) --- updated-dependencies: - dependency-name: github.com/cosmos/gogoproto dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update authz grant examples * Enable larger wasm bytecode upload for gov proposals (CosmWasm#1095) * Enable larger wasm bytecode upload for gov proposals * Set max proposal wasm code size to 3MB * Bump SDK to v0.45.11 * Fix license head * Fix README header * Bump version go to 1.19 (CosmWasm#1044) * bump go 1.19 * add change log * correct change log * Provide source, builder and codehash information in store code proposal message * Implement source, builder, code_info for StoreAndInstantiateProposal * Apply review recommendations * Make linter happy * Fix tests * Formatting only Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlos Salas <giansalex@gmail.com> Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com> Co-authored-by: GNaD13 <89174180+GNaD13@users.noreply.github.com>

* bump go 1.19 * add change log * correct change log

…proposal message (CosmWasm#1072) * Provide source, builder and codehash information in store code proposal message * Make linter happy * Update x/wasm/simulation/proposals.go Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> * Update x/wasm/client/cli/gov_tx.go * Update x/wasm/client/cli/gov_tx.go * Bump github.com/cosmos/gogoproto from 1.4.2 to 1.4.3 Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/cosmos/gogoproto/releases) - [Changelog](https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md) - [Commits](cosmos/gogoproto@v1.4.2...v1.4.3) --- updated-dependencies: - dependency-name: github.com/cosmos/gogoproto dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update authz grant examples * Enable larger wasm bytecode upload for gov proposals (CosmWasm#1095) * Enable larger wasm bytecode upload for gov proposals * Set max proposal wasm code size to 3MB * Bump SDK to v0.45.11 * Fix license head * Fix README header * Bump version go to 1.19 (CosmWasm#1044) * bump go 1.19 * add change log * correct change log * Provide source, builder and codehash information in store code proposal message * Implement source, builder, code_info for StoreAndInstantiateProposal * Apply review recommendations * Make linter happy * Fix tests * Formatting only Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlos Salas <giansalex@gmail.com> Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com> Co-authored-by: GNaD13 <89174180+GNaD13@users.noreply.github.com>

* bump go 1.19 * add change log * correct change log

…proposal message (CosmWasm#1072) * Provide source, builder and codehash information in store code proposal message * Make linter happy * Update x/wasm/simulation/proposals.go Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> * Update x/wasm/client/cli/gov_tx.go * Update x/wasm/client/cli/gov_tx.go * Bump github.com/cosmos/gogoproto from 1.4.2 to 1.4.3 Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/cosmos/gogoproto/releases) - [Changelog](https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md) - [Commits](cosmos/gogoproto@v1.4.2...v1.4.3) --- updated-dependencies: - dependency-name: github.com/cosmos/gogoproto dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update authz grant examples * Enable larger wasm bytecode upload for gov proposals (CosmWasm#1095) * Enable larger wasm bytecode upload for gov proposals * Set max proposal wasm code size to 3MB * Bump SDK to v0.45.11 * Fix license head * Fix README header * Bump version go to 1.19 (CosmWasm#1044) * bump go 1.19 * add change log * correct change log * Provide source, builder and codehash information in store code proposal message * Implement source, builder, code_info for StoreAndInstantiateProposal * Apply review recommendations * Make linter happy * Fix tests * Formatting only Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlos Salas <giansalex@gmail.com> Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com> Co-authored-by: GNaD13 <89174180+GNaD13@users.noreply.github.com>

bump go 1.19

86e4da5

GNaD13 requested a review from alpe as a code owner October 9, 2022 15:33

GNaD13 closed this Nov 7, 2022

GNaD13 deleted the dang/bump-go-minimum1.19 branch November 7, 2022 15:54

alpe reviewed Nov 17, 2022

View reviewed changes

GNaD13 restored the dang/bump-go-minimum1.19 branch November 17, 2022 18:08

GNaD13 reopened this Nov 17, 2022

Merge branch 'main' into dang/bump-go-minimum1.19

68ea6f5

GNaD13 added 4 commits November 18, 2022 01:15

add change log

ba4e7bb

merge main

d3d5abf

add changelog

e36bbee

correct change log

d4b3868

alpe merged commit fc476aa into CosmWasm:main Nov 18, 2022

orkunkl pushed a commit that referenced this pull request Nov 21, 2022

Bump version go to 1.19 (#1044)

9236aaa

* bump go 1.19 * add change log * correct change log

NoahSaso pushed a commit to NoahSaso/wasmd that referenced this pull request Dec 2, 2022

Bump version go to 1.19 (CosmWasm#1044)

29a58f7

* bump go 1.19 * add change log * correct change log

Magicloud pushed a commit to fpco/wasmd that referenced this pull request Jan 13, 2023

Bump version go to 1.19 (CosmWasm#1044)

b3e88c3

* bump go 1.19 * add change log * correct change log

conorpp pushed a commit to wormhole-foundation/wasmd that referenced this pull request Feb 1, 2023

Bump version go to 1.19 (CosmWasm#1044)

bf8af4e

* bump go 1.19 * add change log * correct change log

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump version go to 1.19 #1044

Bump version go to 1.19 #1044

GNaD13 commented Oct 9, 2022

alpe commented Oct 10, 2022

GNaD13 commented Oct 16, 2022

alpe commented Nov 11, 2022

alpe commented Nov 17, 2022

alpe Nov 17, 2022

GNaD13 Nov 17, 2022

alpe Nov 17, 2022

alpe Nov 17, 2022

GNaD13 commented Nov 17, 2022 •

edited

Loading

codecov bot commented Nov 17, 2022 •

edited

Loading

alpe commented Nov 18, 2022

Bump version go to 1.19 #1044

Bump version go to 1.19 #1044

Conversation

GNaD13 commented Oct 9, 2022

alpe commented Oct 10, 2022

GNaD13 commented Oct 16, 2022

alpe commented Nov 11, 2022

alpe commented Nov 17, 2022

alpe Nov 17, 2022

Choose a reason for hiding this comment

GNaD13 Nov 17, 2022

Choose a reason for hiding this comment

alpe Nov 17, 2022

Choose a reason for hiding this comment

alpe Nov 17, 2022

Choose a reason for hiding this comment

GNaD13 commented Nov 17, 2022 • edited Loading

codecov bot commented Nov 17, 2022 • edited Loading

Codecov Report

alpe commented Nov 18, 2022

GNaD13 commented Nov 17, 2022 •

edited

Loading

codecov bot commented Nov 17, 2022 •

edited

Loading