Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] 1076 feedback #1087

Closed
wants to merge 7 commits into from
Closed

[DO NOT MERGE] 1076 feedback #1087

wants to merge 7 commits into from

Conversation

alpe
Copy link
Member

@alpe alpe commented Nov 9, 2022

@GNaD13: As I wrote on #1076 your changes were almost perfect. 💯

Adding some ValidateBasic and some minor code updates as review feedback. Please apply the changes as you like.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #1087 (a1b63bf) into main (a9ce273) will increase coverage by 0.15%.
The diff coverage is 91.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
+ Coverage   59.27%   59.42%   +0.15%     
==========================================
  Files          53       53              
  Lines        6758     6783      +25     
==========================================
+ Hits         4006     4031      +25     
+ Misses       2456     2454       -2     
- Partials      296      298       +2     
Impacted Files Coverage Δ
x/wasm/keeper/querier.go 72.19% <ø> (-0.13%) ⬇️
x/wasm/types/genesis.go 87.87% <42.85%> (-5.57%) ⬇️
x/wasm/keeper/genesis.go 89.47% <100.00%> (+0.14%) ⬆️
x/wasm/keeper/keeper.go 87.40% <100.00%> (-0.02%) ⬇️
x/wasm/types/test_fixtures.go 95.04% <100.00%> (-0.58%) ⬇️
x/wasm/types/types.go 64.53% <100.00%> (+4.32%) ⬆️

@GNaD13
Copy link
Contributor

GNaD13 commented Nov 9, 2022

@GNaD13: As I wrote on #1076 your changes were almost perfect. 100

Adding some ValidateBasic and some minor code updates as review feedback. Please apply the changes as you like.

Tysm for your reviews :3

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2022

⚠️ The sha of the head commit of this PR conflicts with #1076. Mergify cannot evaluate rules on this PR. ⚠️

@alpe alpe closed this Nov 11, 2022
@alpe alpe deleted the 1076_feedback branch November 11, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants