-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to IBC v4.2.0 with interchain-accounts v0.2.4 #1088
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1088 +/- ##
=======================================
Coverage 59.79% 59.80%
=======================================
Files 54 54
Lines 7273 7306 +33
=======================================
+ Hits 4349 4369 +20
- Misses 2612 2621 +9
- Partials 312 316 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! Many changes but the extensive testing you provided covers them very well! 💯
Get ibc app version from middleware
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
* main: Upgrade to IBC v4.2.0 with interchain-accounts v0.2.4 (#1088)
* Upgrade to IBC v4.2.0 with interchain-accounts v0.2.4 * Fix linter issues * Test version handshake * Add more ibc e2e scenarios * Add fee middleware to wasm * Get ibc app version from middleware
* Upgrade to IBC v4.2.0 with interchain-accounts v0.2.4 * Fix linter issues * Test version handshake * Add more ibc e2e scenarios * Add fee middleware to wasm * Get ibc app version from middleware
* Upgrade to IBC v4.2.0 with interchain-accounts v0.2.4 * Fix linter issues * Test version handshake * Add more ibc e2e scenarios * Add fee middleware to wasm * Get ibc app version from middleware
…om v0.45.9 to v0.45.12 Reference: CosmWasm/wasmd#1088
…om v0.45.9 to v0.45.12 Reference: CosmWasm/wasmd#1088
…#1088) cherry-pick original CosmWasm#1088 except ICA part. * Upgrade to IBC v4.2.0 with interchain-accounts v0.2.4 * Fix linter issues * Test version handshake * Add more ibc e2e scenarios * Add fee middleware to wasm * Get ibc app version from middleware
* feat: Upgrade to IBC v4.2.0 with interchain-accounts v0.2.4 (CosmWasm#1088) cherry-pick original CosmWasm#1088 except ICA part. * Upgrade to IBC v4.2.0 with interchain-accounts v0.2.4 * Fix linter issues * Test version handshake * Add more ibc e2e scenarios * Add fee middleware to wasm * Get ibc app version from middleware * feat: remove channel hack cherry-picking d522e54 * docs: add this PR to CHANGELOG * chore: execute go fmt * fix: add missed e2e ibc-fees test in cherry-pick * chore: make format * fix: fix missed duplicating changes for app/app.go to appplus/app.go * build: upgrade finschia-sdk to v0.48.0-rc1 --------- Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Resolves #960
Upgrade to ibc-go v4.2.0
Includes:
You can read more about ibc fees middleware included in v4 in this article
Notes for users
In order to submit a relayer fee for an IBC packet, a
MsgPayPacketFee
needs to be in the TX before the packet creating msg.