Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ibc-go v7 beta2 + protoVer=0.11.5 #1190

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

gjermundgaraba
Copy link
Contributor

Updated to use the newest ibc-go v7 beta tag and the latest version of the proto builder image.

@gjermundgaraba gjermundgaraba requested a review from alpe as a code owner January 29, 2023 10:38
@sonarcloud
Copy link

sonarcloud bot commented Jan 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #1190 (6a0c2a3) into develop_sdk47 (9df3f60) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           develop_sdk47    #1190      +/-   ##
=================================================
- Coverage          59.30%   59.24%   -0.06%     
=================================================
  Files                 53       53              
  Lines               7237     7244       +7     
=================================================
  Hits                4292     4292              
- Misses              2650     2657       +7     
  Partials             295      295              
Impacted Files Coverage Δ
app/ante.go 64.28% <ø> (ø)
app/app.go 86.61% <ø> (ø)
x/wasm/ibc.go 67.23% <ø> (ø)
x/wasm/keeper/handler_plugin.go 85.05% <ø> (ø)
x/wasm/keeper/handler_plugin_encoders.go 80.30% <ø> (ø)
x/wasm/keeper/ibc.go 77.77% <ø> (ø)
x/wasm/keeper/query_plugins.go 82.55% <ø> (ø)
x/wasm/types/types.go 57.70% <0.00%> (-1.84%) ⬇️

@faddat
Copy link
Contributor

faddat commented Jan 29, 2023

dude thank you!

Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot of the PR! 🥇

@@ -170,7 +170,7 @@ format: format-tools
###############################################################################
### Protobuf ###
###############################################################################
protoVer=0.11.2
protoVer=0.11.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -9,7 +9,7 @@ require (
github.com/cosmos/gogogateway v1.2.0 // indirect
github.com/cosmos/gogoproto v1.4.3
github.com/cosmos/iavl v0.19.4
github.com/cosmos/ibc-go/v6 v6.0.0-20230124092939-cfcdec0b33a2
github.com/cosmos/ibc-go/v7 v7.0.0-beta2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -423,3 +423,14 @@ func isSubset(super, sub []string) bool {
}
return matches == len(sub)
}

// AllAuthorizedAddresses returns the list of authorized addresses. Can be empty.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be included in the #1189 backport. It is easier track changes separately for a clean history

@alpe alpe merged commit 6a49301 into CosmWasm:develop_sdk47 Jan 30, 2023
@gjermundgaraba gjermundgaraba deleted the develop_sdk47 branch January 30, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants