Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run checkLibwasmVersion automatically on start (backport #1338) #1352

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 20, 2023

This is an automatic backport of pull request #1338 done by Mergify.

* Don't run checkLibwasmVersion automatically on start

* Remove unused preRunFn, chainPreRuns

* Add documentation to CheckLibwasmVersion

* Add skip wasmvm version flag

* Linter false positive

* Review feedback

* Pass expected version

---------

Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
(cherry picked from commit 0929168)

# Conflicts:
#	x/wasm/module.go
@mergify mergify bot requested a review from alpe as a code owner April 20, 2023 14:51
@mergify mergify bot added the conflicts label Apr 20, 2023
@alpe alpe removed the conflicts label Apr 21, 2023
@alpe alpe merged commit e06c445 into main Apr 21, 2023
@mergify mergify bot deleted the mergify/bp/main/pr-1338 branch April 21, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants