Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cosmos-sdk@goz-phase-3 #138

Merged
merged 6 commits into from
Jun 15, 2020
Merged

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jun 10, 2020

Resolved #128
Closes #127 (obsolete)
Closes #132 (obsolete)
Closes #108 (obsolete)
Closes #129 (cosmos-sdk-0.39 branch not 0.10)

This PR is very much based on the fine work in #108 .

TODO

  • cleanup files from Update gaia to master #108 like .github, docs/,... folder

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added relevant godoc comments.

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the Github PR explorer


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alpe alpe changed the title Upgrade cosmos-sdk Upgrade to cosmos-sdk@goz-phase-3 Jun 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #138 into cosmos-sdk-0.39 will decrease coverage by 30.89%.
The diff coverage is 10.82%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           cosmos-sdk-0.39     #138       +/-   ##
====================================================
- Coverage            61.99%   31.09%   -30.90%     
====================================================
  Files                   20       22        +2     
  Lines                 1768     3653     +1885     
====================================================
+ Hits                  1096     1136       +40     
- Misses                 578     2422     +1844     
- Partials                94       95        +1     
Impacted Files Coverage Δ
app/genesis.go 0.00% <0.00%> (ø)
x/wasm/internal/keeper/genesis.go 0.00% <0.00%> (ø)
x/wasm/internal/types/genesis.go 0.00% <ø> (ø)
x/wasm/internal/types/msg.go 44.33% <ø> (ø)
x/wasm/internal/types/types.go 0.00% <0.00%> (ø)
x/wasm/module.go 18.18% <0.00%> (ø)
x/wasm/internal/types/types.pb.go 0.53% <0.53%> (ø)
app/export.go 7.31% <60.00%> (ø)
x/wasm/handler.go 58.55% <78.57%> (+0.61%) ⬆️
lcd_test/helpers.go 75.36% <94.11%> (-0.36%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5fdbb...ea8ec3c. Read the comment docs.

@ethanfrey ethanfrey self-requested a review June 10, 2020 11:23
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work.

Added some comments. The ones on the tops (about docs) were just what I noticed looking at the diff. We can also remove large section of the docs (which came from gaia) as we will likely stop merging in gaia changes and just pull in from cosmos-sdk

.github/ISSUE_TEMPLATE/bug-report.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
x/wasm/handler.go Show resolved Hide resolved
x/wasm/internal/keeper/keeper.go Show resolved Hide resolved
x/wasm/internal/types/types.go Show resolved Hide resolved
x/wasm/internal/types/types.proto Outdated Show resolved Hide resolved
x/wasm/internal/types/types.proto Outdated Show resolved Hide resolved
@alpe alpe changed the base branch from master to cosmos-sdk-0.39 June 10, 2020 12:59
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good now. I might just merge this PR (if only it wasn't draft)

@@ -30,7 +30,7 @@ There is some work done in `go-cosmwasm` to extend support, but it is rather tri
With the `v0.6.0` tag, we are entering semver. That means anything with `v0.6.x` tags is compatible with each other, and everything with `v0.7.x` tags is compatible with each other. We will have a series of minor version updates prior to `v1.0.0`, where we offer strong backwards compatibility guarantees. In particular, work has begun in the `cosmwasm` library on `v0.8`, which will change many internal APIs, in order to allow adding other languages for writing smart contracts. We hope to stabilize much of this well before `v1`, but we are still in the process of learning from real-world use-cases

## Encoding

The used cosmos-sdk version is in transition migrating from amino encoding to protobuf for state. So are we now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

app/app.go Show resolved Hide resolved
@ethanfrey ethanfrey marked this pull request as ready for review June 14, 2020 20:44
@ethanfrey ethanfrey merged commit a603001 into cosmos-sdk-0.39 Jun 15, 2020
@ethanfrey ethanfrey deleted the upgrade_0.9_wip branch June 15, 2020 22:27
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
…2.3 to 0.32.4

* Bump github.com/tendermint/tendermint from 0.32.3 to 0.32.4

Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.32.3 to 0.32.4.
- [Release notes](https://github.com/tendermint/tendermint/releases)
- [Changelog](https://github.com/tendermint/tendermint/blob/master/CHANGELOG.md)
- [Commits](tendermint/tendermint@v0.32.3...v0.32.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Update go.{mod, sum}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment