-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to cosmos-sdk@goz-phase-3 #138
Conversation
Codecov Report
@@ Coverage Diff @@
## cosmos-sdk-0.39 #138 +/- ##
====================================================
- Coverage 61.99% 31.09% -30.90%
====================================================
Files 20 22 +2
Lines 1768 3653 +1885
====================================================
+ Hits 1096 1136 +40
- Misses 578 2422 +1844
- Partials 94 95 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work.
Added some comments. The ones on the tops (about docs) were just what I noticed looking at the diff. We can also remove large section of the docs (which came from gaia) as we will likely stop merging in gaia changes and just pull in from cosmos-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks good now. I might just merge this PR (if only it wasn't draft)
@@ -30,7 +30,7 @@ There is some work done in `go-cosmwasm` to extend support, but it is rather tri | |||
With the `v0.6.0` tag, we are entering semver. That means anything with `v0.6.x` tags is compatible with each other, and everything with `v0.7.x` tags is compatible with each other. We will have a series of minor version updates prior to `v1.0.0`, where we offer strong backwards compatibility guarantees. In particular, work has begun in the `cosmwasm` library on `v0.8`, which will change many internal APIs, in order to allow adding other languages for writing smart contracts. We hope to stabilize much of this well before `v1`, but we are still in the process of learning from real-world use-cases | |||
|
|||
## Encoding | |||
|
|||
The used cosmos-sdk version is in transition migrating from amino encoding to protobuf for state. So are we now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…2.3 to 0.32.4 * Bump github.com/tendermint/tendermint from 0.32.3 to 0.32.4 Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.32.3 to 0.32.4. - [Release notes](https://github.com/tendermint/tendermint/releases) - [Changelog](https://github.com/tendermint/tendermint/blob/master/CHANGELOG.md) - [Commits](tendermint/tendermint@v0.32.3...v0.32.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update go.{mod, sum}
Resolved #128
Closes #127 (obsolete)
Closes #132 (obsolete)
Closes #108 (obsolete)
Closes #129 (cosmos-sdk-0.39 branch not 0.10)
This PR is very much based on the fine work in #108 .
TODO
cleanup files from Update gaia to master #108 like
.github
,docs/
,... folderTargeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added relevant
godoc
comments.Added a relevant changelog entry to the
Unreleased
section inCHANGELOG.md
Re-reviewed
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)