Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/cosmos/ibc-go/v7 from 7.1.0 to 7.2.0 #1459

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 23, 2023

Bumps github.com/cosmos/ibc-go/v7 from 7.1.0 to 7.2.0.

Release notes

Sourced from github.com/cosmos/ibc-go/v7's releases.

v7.2.0

This release fixes a bug introduced in v7.0.0 that broke transaction signing with ledger. All past releases in the v7 line are affected and we recommend not using them. Thank you to Chainapsis and Stride for reporting this bug. Please also note that this release requires a coordinated upgrade.

Please see the v7.2.0 changelog for the full set of changes included in this release.

dependencies

  • Cosmos SDK has been bumped to v0.47.3.
  • CometBFT has been bumped to v0.37.2.

apps/transfer

  • Implementation of function Type() of LegacyMsg interface has been re-introduced in MsgTransfer.

apps/29-fee

  • Implementation of function Type() of LegacyMsg interface has been re-introduced in MsgPayPacketFee and MsgPayPacketFeeAsync.

Special thanks to our external contributors on this release: @​faddat


To learn more about ibc-go versioning, please read our RELEASES.md.

IMPORTANT: Please read the migration guides for any versions of ibc-go that you might be going through when upgrading to this version. For example: if you upgrade from the IBC module contained in the Cosmos SDK 0.42.0 to SDK v0.47.3 and ibc-go v7.2.0, please follow:

  1. The migration from SDK 0.41.x or 0.42.x to the IBC module in the ibc-go repository based on the SDK v0.44.x.
  2. The migration from ibc-go v1 to v2.
  3. The migration from ibc-go v2 to v3.
  4. The migration from ibc-go v3 to v4.
  5. The migration from ibc-go v4 to v5.
  6. The migration from ibc-go v5 to v6.
  7. The migration from ibc-go v6 to v7.
  8. The migration from ibc-go v7 to v7.1.
Changelog

Sourced from github.com/cosmos/ibc-go/v7's changelog.

v7.2.0 - 2023-06-22

Dependencies

  • #3810 Update Cosmos SDK to v0.47.3.
  • #3862 Update CometBFT to v0.37.2.

State Machine Breaking

  • #3907 Re-implemented missing functions of LegacyMsg interface to fix transaction signing with ledger.
Commits
  • d02ab9d prepare changelog for v7.2.0
  • 4e7724b Update CHANGELOG.md
  • 571bfc6 Bump ubuntu image used, 22.04 has a more recent version of libc that should m...
  • d7d3e1a fix(statemachine)!: re-implement legacy msg interface (backport #3907) (#3938)
  • 532929b build(deps): Bump github.com/cometbft/cometbft from 0.37.1 to 0.37.2 (backpor...
  • 3252269 barberry (bump SDK v0.47.3) (backport #3810) (#3931)
  • a78c61d retract previous v7 releases with ledger transaction signing bug (#3925)
  • 501156e chore: remove simd testnet cmd and cosmossdk.io/simapp dependency (#3554) (#3...
  • 71c6d71 Update CHANGELOG.md
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from alpe as a code owner June 23, 2023 08:58
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 23, 2023
@alpe
Copy link
Contributor

alpe commented Jun 26, 2023

system tests are failing 🤔

@alpe
Copy link
Contributor

alpe commented Jun 29, 2023

The upgrade should include moving to ibc-go's capability module

@alpe alpe added the blocked label Jun 29, 2023
@alpe
Copy link
Contributor

alpe commented Jun 29, 2023

All dependencies are on hold until #1470 is solved

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cosmos/ibc-go/v7-7.2.0 branch from c452e70 to fe2a4c2 Compare July 6, 2023 11:28
@alpe alpe removed the blocked label Jul 6, 2023
Bumps [github.com/cosmos/ibc-go/v7](https://github.com/cosmos/ibc-go) from 7.1.0 to 7.2.0.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v7.2.0/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v7.1.0...v7.2.0)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v7
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cosmos/ibc-go/v7-7.2.0 branch from fe2a4c2 to 3ab22e8 Compare July 6, 2023 11:32
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1459 (3ab22e8) into main (17e14a4) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1459      +/-   ##
==========================================
- Coverage   57.95%   57.92%   -0.03%     
==========================================
  Files          64       64              
  Lines        8405     8405              
==========================================
- Hits         4871     4869       -2     
- Misses       3128     3129       +1     
- Partials      406      407       +1     

see 1 file with indirect coverage changes

@alpe
Copy link
Contributor

alpe commented Jul 6, 2023

@dependabot rebase

@alpe alpe merged commit db93d7b into main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant