Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use large resouce class for CI system tests #1465

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

@alpe alpe requested a review from pinosu June 28, 2023 08:47
@alpe alpe marked this pull request as draft June 28, 2023 09:05
@alpe
Copy link
Contributor Author

alpe commented Jun 28, 2023

Still failing

Comment on lines 116 to 118
- run:
name: Build and run system tests
command: make test-system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks duplicate.. probably should be removed

@alpe
Copy link
Contributor Author

alpe commented Jun 29, 2023

I am going to revert changes to have only the resource class here. See #1470

@alpe alpe force-pushed the systemtest_resources branch from 263a433 to 1c7a425 Compare June 29, 2023 08:58
@alpe alpe marked this pull request as ready for review June 29, 2023 08:59
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit 2496105 into main Jun 30, 2023
@alpe alpe deleted the systemtest_resources branch June 30, 2023 08:39
@faddat faddat mentioned this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants