Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label validation error #1555

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fix label validation error #1555

merged 1 commit into from
Aug 17, 2023

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Aug 14, 2023

Resolves #1554

@pinosu pinosu requested a review from alpe as a code owner August 14, 2023 13:48
@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #1555 (f03abf6) into main (33df4ae) will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1555      +/-   ##
==========================================
+ Coverage   58.00%   58.03%   +0.02%     
==========================================
  Files          64       64              
  Lines        8640     8640              
==========================================
+ Hits         5012     5014       +2     
+ Misses       3215     3214       -1     
+ Partials      413      412       -1
Files Changed Coverage Δ
x/wasm/types/tx.go 47.26% <33.33%> (ø)

... and 1 file with indirect coverage changes

@pinosu pinosu requested a review from chipshort August 14, 2023 14:55
chipshort
chipshort approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alpe
alpe approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pinosu pinosu merged commit 08c517b into main Aug 17, 2023
@pinosu pinosu deleted the 1554-label_err branch August 17, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort chipshort approved these changes

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instantiate Label validation error is misleading
3 participants
@pinosu @alpe @chipshort