Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ToWasmVMGas/FromWasmVMGas code level documentation #1564

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Improve ToWasmVMGas/FromWasmVMGas code level documentation #1564

merged 1 commit into from
Aug 24, 2023

Conversation

webmaster128
Copy link
Member

to support the issue in #1536

@webmaster128 webmaster128 requested a review from alpe as a code owner August 21, 2023 11:08
chipshort
chipshort approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pinosu
pinosu approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pinosu pinosu added the backport/v0.3x Backport patches to sdk45 release branch label Aug 23, 2023
@pinosu pinosu merged commit 881d6a7 into main Aug 24, 2023
mergify bot pushed a commit that referenced this pull request Aug 24, 2023
@webmaster128 @mergify
Improve ToWasmVMGas/FromWasmVMGas code level documentation (#1564)
78281f2 
(cherry picked from commit 881d6a7)
@mergify mergify bot mentioned this pull request Aug 24, 2023
Merged
@webmaster128 webmaster128 deleted the improve-cosmwasm-gas-docs branch August 24, 2023 09:10
pinosu pushed a commit that referenced this pull request Aug 24, 2023
@mergify @webmaster128
Improve ToWasmVMGas/FromWasmVMGas code level documentation (#1564) (#…
aae393e 
…1569)

(cherry picked from commit 881d6a7)

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

@chipshort chipshort chipshort approved these changes

@alpe alpe Awaiting requested review from alpe

Assignees
No one assigned
Labels
backport/v0.3x Backport patches to sdk45 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webmaster128 @chipshort @pinosu