Add label validation for non printable chars #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1650 +/- ##
==========================================
+ Coverage 56.56% 56.62% +0.05%
==========================================
Files 62 62
Lines 8194 8200 +6
==========================================
+ Hits 4635 4643 +8
+ Misses 3121 3120 -1
+ Partials 438 437 -1
|
alpe
reviewed
Oct 5, 2023
x/wasm/types/validation.go
Outdated
| return !unicode.IsGraphic(r) | ||
| }) | ||
| if label != labelWithoutNonPrintableChars { | ||
| return ErrInvalid.Wrap("label must not have non printable characters") |
There was a problem hiding this comment.
nit: let's avoid double negative ;-)
Suggested change
| return ErrInvalid.Wrap("label must not have non printable characters") | |
| return ErrInvalid.Wrap("label must have printable characters only") |
alpe
approved these changes
Oct 9, 2023
| @@ -45,6 +46,15 @@ func ValidateLabel(label string) error { | |||
| if label != strings.TrimSpace(label) { | |||
| return ErrInvalid.Wrap("label must not start/end with whitespaces") | |||
| } | |||
| labelWithPrintableCharsOnly := strings.Map(func(r rune) rune { | |||
There was a problem hiding this comment.
very nice use of strings.Map 👍
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
* Add label validation for non printable chars * Fix printable chars check (cherry picked from commit 1a22c29)
pinosu
added a commit
that referenced
this pull request
Oct 11, 2023
* Add label validation for non printable chars * Fix printable chars check (cherry picked from commit 1a22c29)
pinosu
added a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1623