Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cosmos-sdk to v0.50.6 #1865

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Bump cosmos-sdk to v0.50.6 #1865

merged 2 commits into from
Apr 22, 2024

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Apr 22, 2024

No description provided.

@pinosu pinosu requested a review from webmaster128 April 22, 2024 11:27
@webmaster128
Copy link
Member

We got a build fail here:

?       github.com/CosmWasm/wasmd/app/upgrades  [no test files]
?       github.com/CosmWasm/wasmd/cmd/wasmd     [no test files]
?       github.com/CosmWasm/wasmd/x/wasm/exported       [no test files]
?       github.com/CosmWasm/wasmd/x/wasm/keeper/wasmtesting     [no test files]
# github.com/CosmWasm/wasmd/x/wasm/types [github.com/CosmWasm/wasmd/x/wasm/types.test]
x/wasm/types/iavl_range_test.go:20:31: cannot use memdb (variable of type *"github.com/cosmos/cosmos-db".MemDB) as "github.com/cosmos/iavl/db".DB value in argument to iavl2.NewMutableTree: *"github.com/cosmos/cosmos-db".MemDB does not implement "github.com/cosmos/iavl/db".DB (wrong type for method Iterator)
                have Iterator([]byte, []byte) ("github.com/cosmos/cosmos-db".Iterator, error)
                want Iterator([]byte, []byte) ("github.com/cosmos/iavl/db".Iterator, error)
FAIL    github.com/CosmWasm/wasmd/x/wasm/types [build failed]

@pinosu
Copy link
Contributor Author

pinosu commented Apr 22, 2024

We got a build fail here:

?       github.com/CosmWasm/wasmd/app/upgrades  [no test files]
?       github.com/CosmWasm/wasmd/cmd/wasmd     [no test files]
?       github.com/CosmWasm/wasmd/x/wasm/exported       [no test files]
?       github.com/CosmWasm/wasmd/x/wasm/keeper/wasmtesting     [no test files]
# github.com/CosmWasm/wasmd/x/wasm/types [github.com/CosmWasm/wasmd/x/wasm/types.test]
x/wasm/types/iavl_range_test.go:20:31: cannot use memdb (variable of type *"github.com/cosmos/cosmos-db".MemDB) as "github.com/cosmos/iavl/db".DB value in argument to iavl2.NewMutableTree: *"github.com/cosmos/cosmos-db".MemDB does not implement "github.com/cosmos/iavl/db".DB (wrong type for method Iterator)
                have Iterator([]byte, []byte) ("github.com/cosmos/cosmos-db".Iterator, error)
                want Iterator([]byte, []byte) ("github.com/cosmos/iavl/db".Iterator, error)
FAIL    github.com/CosmWasm/wasmd/x/wasm/types [build failed]

I will fix it now

@pinosu pinosu requested a review from webmaster128 April 22, 2024 13:33
@pinosu pinosu merged commit a1789c0 into main Apr 22, 2024
10 of 11 checks passed
@pinosu pinosu deleted the bump_sdk_0.50.6 branch April 22, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinosu @webmaster128