Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ambiguous Code attribute #204

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Rename ambiguous Code attribute #204

merged 1 commit into from
Jul 20, 2020

Conversation

alpe
Copy link
Member

@alpe alpe commented Jul 17, 2020

Code -> CodeID


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alpe alpe requested a review from ethanfrey as a code owner July 17, 2020 15:03
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is 90.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   71.71%   71.71%           
=======================================
  Files          27       27           
  Lines        2584     2584           
=======================================
  Hits         1853     1853           
  Misses        621      621           
  Partials      110      110           
Impacted Files Coverage Δ
x/wasm/internal/keeper/test_common.go 86.89% <0.00%> (ø)
x/wasm/handler.go 50.00% <66.66%> (ø)
x/wasm/internal/keeper/handler_plugin.go 74.43% <100.00%> (ø)
x/wasm/internal/keeper/proposal_handler.go 69.76% <100.00%> (ø)
x/wasm/internal/types/msg.go 42.45% <100.00%> (ø)
x/wasm/internal/types/proposal.go 94.94% <100.00%> (ø)
x/wasm/internal/types/test_fixtures.go 91.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 774f6d7...db464d8. Read the comment docs.

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

Please add a migration guide file for the clients mentioning this

@alpe
Copy link
Member Author

alpe commented Jul 20, 2020

This PR not affect clients as the json name was code_id before and was not modified. See https://github.com/CosmWasm/wasmd/pull/204/files#diff-8c1459d12d1cdd42896fc113ef3b8335R170

@alpe alpe merged commit 02a54d3 into master Jul 20, 2020
@alpe alpe deleted the code_id branch July 20, 2020 08:29
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
* docs: Deprecate gopath

- deprecate setting of gopath in docs and bump min version to go1.13

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>

* Update docs/installation.md

* change other translations to go env path

* Apply suggestions from code review

Co-Authored-By: Alessio Treglia <alessio@tendermint.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants