Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Staking BeginBlocker #217

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Enable Staking BeginBlocker #217

merged 1 commit into from
Jul 23, 2020

Conversation

ethanfrey
Copy link
Member

This is needed to enable the historical info endpoint.

Reference (discord):

fedekunze:
So the info is pruned if current height - queried height > 100
That could be a reason
Also, did you add the staking module to begin blockers in the app setup?

Check https://docs.cosmos.network/master/ibc/integration.html#application-abci-ordering for reference

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added relevant godoc comments.

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the Github PR explorer


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #217 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   72.02%   72.02%           
=======================================
  Files          27       27           
  Lines        2624     2624           
=======================================
  Hits         1890     1890           
+ Misses        622      621    -1     
- Partials      112      113    +1     
Impacted Files Coverage Δ
app/app.go 89.34% <100.00%> (ø)
x/wasm/internal/keeper/keeper.go 91.00% <0.00%> (-0.55%) ⬇️
lcd_test/helpers.go 75.71% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04cfcdc...fd81e60. Read the comment docs.

@ethanfrey ethanfrey merged commit 3d04299 into master Jul 23, 2020
@ethanfrey ethanfrey deleted the enable-historical-info branch July 23, 2020 13:21
Copy link
Member

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants