Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go cosmwasm #218

Merged
merged 5 commits into from
Jul 24, 2020
Merged

Update go cosmwasm #218

merged 5 commits into from
Jul 24, 2020

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Jul 24, 2020

Closes #194
Closes #197

  • Upgrades to go-cosmwasm v0.10.0-alpha2
  • Upgrade all CosmWasm test contracts to v0.10
  • All gas multipiers applied inside wasmd (not in go-cosmwasm)
  • Humanize and Canonical charge gas for usage

TODO:

  • Storage loop never triggers out of gas panic (but cpu loop does)

  • Issue in TestImportContractWithCodeHistoryReset (stack trace too large to debug)

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added relevant godoc comments.

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the Github PR explorer


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ethanfrey ethanfrey requested a review from alpe July 24, 2020 09:09
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #218 into master will increase coverage by 0.16%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   71.95%   72.11%   +0.16%     
==========================================
  Files          27       27              
  Lines        2624     2632       +8     
==========================================
+ Hits         1888     1898      +10     
+ Misses        623      622       -1     
+ Partials      113      112       -1     
Impacted Files Coverage Δ
x/wasm/internal/types/types.go 23.68% <0.00%> (ø)
x/wasm/internal/keeper/api.go 71.42% <83.33%> (+4.76%) ⬆️
x/wasm/internal/keeper/keeper.go 91.71% <100.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d04299...ff8991e. Read the comment docs.

@ethanfrey ethanfrey marked this pull request as ready for review July 24, 2020 10:09
@ethanfrey
Copy link
Member Author

Awesome @alpe
Thank you!

@ethanfrey ethanfrey merged commit 5224936 into master Jul 24, 2020
@ethanfrey ethanfrey deleted the update-go-cosmwasm branch July 24, 2020 11:58
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use GasMultiplier in the wasm callbacks to convert to wasm gas Charge gas on API callbacks
2 participants