Added rest interface #30

sahith-narahari · 2020-01-19T19:43:38Z

Implements a part of proposal as discussed here #7.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Reviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

…erver

…d-rest-server

codecov-io · 2020-01-19T20:28:46Z

Codecov Report

Merging #30 into master will decrease coverage by 0.59%.
The diff coverage is 44.77%.

@@            Coverage Diff            @@
##           master      #30     +/-   ##
=========================================
- Coverage   61.25%   60.66%   -0.6%     
=========================================
  Files          13       14      +1     
  Lines        1053     1060      +7     
=========================================
- Hits          645      643      -2     
- Misses        349      358      +9     
  Partials       59       59

Impacted Files	Coverage Δ
x/wasm/internal/keeper/querier.go	`23.71% <16.66%> (-4.87%)`	⬇️
x/wasm/handler.go	`83.58% <33.33%> (ø)`	⬆️
x/wasm/internal/keeper/keeper.go	`65% <61.76%> (+0.1%)`	⬆️
x/wasm/internal/keeper/api.go	`66.66% <66.66%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa15e7...329ee04. Read the comment docs.

ethanfrey

Looks good.
Some minor cleanup, but I know you have a new PR coming, so I'll merge this to master now, so we can get less conflicts moving forward

ethanfrey · 2020-01-20T09:57:26Z

x/wasm/client/rest/query.go

+	"github.com/gorilla/mux"
+)
+
+func registerQueryRoutes(cliCtx context.CLIContext, r *mux.Router) {


This file looks good

ethanfrey · 2020-01-20T09:57:53Z

x/wasm/client/rest/query.go

+	}
+}
+
+func queryContractStateSmartHandlerFn(cliCtx context.CLIContext) http.HandlerFunc {


These two should be marked TODO, but as long as you know and will follow up shortly, this is fine

ethanfrey · 2020-01-20T09:58:03Z

x/wasm/client/rest/tx.go

+	"github.com/cosmwasm/wasmd/x/wasm/internal/types"
+)
+
+func registerTxRoutes(cliCtx context.CLIContext, r *mux.Router) {


ethanfrey · 2020-01-20T09:59:44Z

x/wasm/client/rest/tx.go

+const maxSize = 400 * 1024
+
+type storeCodeReq struct {
+	BaseReq   rest.BaseReq `json:"base_req" yaml:"base_req"`


I was thinking this should be "squash", but see that it is not in the cosmos-sdk either.
I guess I should look more into this generic format used everywhere.
Do you know where the docs are?

ethanfrey · 2020-01-20T09:59:52Z

x/wasm/client/rest/tx.go

+
+type storeCodeReq struct {
+	BaseReq   rest.BaseReq `json:"base_req" yaml:"base_req"`
+	WasmBytes []byte       `json:"wasm_bytes"`


missing yaml

ethanfrey · 2020-01-20T10:00:07Z

x/wasm/client/rest/tx.go

+			return
+		}
+
+		// gzip the wasm file


Nice to auto-gzip it here as well 👍

) * build: replace line repositories with finschia repositories * Update x/wasmplus/README.md Co-authored-by: zemyblue <zemyblue@gmail.com> * Update x/wasm/ibc_reflect_test.go Co-authored-by: zemyblue <zemyblue@gmail.com> * Update .github/dependabot.yml Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> * docs: replace a comment contains line with finschia one * build: replace line in Dockerfile with finschia * docs: replace line in README.md with Finschia * docs: update CHANGELOG --------- Co-authored-by: zemyblue <zemyblue@gmail.com> Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>

…CosmWasm#53) * build: replace line repositories with finschia repositories (CosmWasm#30) * build: replace line repositories with finschia repositories * Update x/wasmplus/README.md Co-authored-by: zemyblue <zemyblue@gmail.com> * Update x/wasm/ibc_reflect_test.go Co-authored-by: zemyblue <zemyblue@gmail.com> * Update .github/dependabot.yml Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> * docs: replace a comment contains line with finschia one * build: replace line in Dockerfile with finschia * docs: replace line in README.md with Finschia * docs: update CHANGELOG --------- Co-authored-by: zemyblue <zemyblue@gmail.com> Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> * chore: update changelog for release v0.1.3 (CosmWasm#31) * fix: stop wrap twice the response of handling non-plus wasm message in plus handler (CosmWasm#35) * fix: stop wrap twice non-plus wasm hander's response fix Finschia#33 * test: add tests handling non-plus wasm messages * docs: add this PR to CHANGELOG.md * fix: reflect golangci-lint * fix: simplify how to handle the message in wasmplus * chore: update notice (CosmWasm#44) * chore: update notice * chore: update changelog * fix: delete unnecessary test (CosmWasm#43) * fix: delete unnecessary test * docs: add CHANGELOG * feat: add admin-related events (CosmWasm#46) * add admin-related events in docs * fix ClearAdmin event * cherry-pick upstream admin-related events update * chore: update changelog for release v0.1.4 (CosmWasm#49) * build: update depending wasmvm to v1.1.1-0.11.2-dynamiclink2 and update tests --------- Co-authored-by: zemyblue <zemyblue@gmail.com> Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> Co-authored-by: Daisuke Iuchi <42408108+da1suk8@users.noreply.github.com> Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>

Sahith Reddy Narahari and others added 6 commits January 14, 2020 15:02

Added routes for rest

d33e084

Merge branch 'master' of github.com:cosmwasm/wasmd into vw/add-rest-s…

b9e2bc3

…erver

Added rest interface for store code

6aa15e7

Merge branch 'master' of https://github.com/cosmwasm/wasmd into vw/ad…

d1c1dcf

…d-rest-server

Added txs for rest

386e0f6

Added rest interface for queries

0f8ea58

sahith-narahari requested a review from ethanfrey as a code owner January 19, 2020 19:43

Modified error messages for rest

329ee04

Merge branch 'master' into vw/add-rest-server

2db61ec

ethanfrey approved these changes Jan 20, 2020

View reviewed changes

ethanfrey merged commit 8983d9b into master Jan 20, 2020

ethanfrey deleted the vw/add-rest-server branch January 20, 2020 10:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added rest interface #30

Added rest interface #30

sahith-narahari commented Jan 19, 2020 •

edited

Loading

codecov-io commented Jan 19, 2020

ethanfrey left a comment

ethanfrey Jan 20, 2020

ethanfrey Jan 20, 2020

ethanfrey Jan 20, 2020

ethanfrey Jan 20, 2020

ethanfrey Jan 20, 2020

ethanfrey Jan 20, 2020

Added rest interface #30

Added rest interface #30

Conversation

sahith-narahari commented Jan 19, 2020 • edited Loading

codecov-io commented Jan 19, 2020

Codecov Report

ethanfrey left a comment

Choose a reason for hiding this comment

ethanfrey Jan 20, 2020

Choose a reason for hiding this comment

ethanfrey Jan 20, 2020

Choose a reason for hiding this comment

ethanfrey Jan 20, 2020

Choose a reason for hiding this comment

ethanfrey Jan 20, 2020

Choose a reason for hiding this comment

ethanfrey Jan 20, 2020

Choose a reason for hiding this comment

ethanfrey Jan 20, 2020

Choose a reason for hiding this comment

sahith-narahari commented Jan 19, 2020 •

edited

Loading