Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct directories for commands #307

Closed
wants to merge 1 commit into from
Closed

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 11, 2020

wasmd add-genesis-account command was accessing the wrong folder for the key

Also added some tests from cosmos-sdk simapp

@alpe alpe requested a review from willclarktech November 11, 2020 11:10
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #307 (e21e9b1) into master (cbda602) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   17.49%   17.85%   +0.35%     
==========================================
  Files          35       39       +4     
  Lines       10505    10890     +385     
==========================================
+ Hits         1838     1944     +106     
- Misses       8566     8833     +267     
- Partials      101      113      +12     
Impacted Files Coverage Δ
cmd/wasmd/root.go 51.68% <100.00%> (ø)
cmd/wasmd/testnet.go 0.00% <0.00%> (ø)
cmd/wasmd/main.go 0.00% <0.00%> (ø)
cmd/wasmd/genaccounts.go 62.36% <0.00%> (ø)
x/wasm/internal/keeper/keeper.go 90.30% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbda602...e21e9b1. Read the comment docs.

@alpe alpe removed the request for review from willclarktech November 11, 2020 13:16
@alpe alpe self-assigned this Nov 11, 2020
@alpe alpe marked this pull request as draft November 11, 2020 13:16
@alpe
Copy link
Contributor Author

alpe commented Nov 13, 2020

Closing this in favour of #308

@alpe alpe closed this Nov 13, 2020
@alpe alpe deleted the gen_accounts_fix branch November 13, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant